Claude finished @Bkm016's task —— View job • claude/issue-110-20250809-1920 • Create PR ➔

NPC Title Stacking Issue Fixed! ✅

Issue: NPC titles are not properly removed when players leave the NPC's visible range, causing multiple titles to stack when players re-enter the area.

Todo List:

Read repository setup instructions (CLAUDE.md)
Explore codebase to understand NPC title management system
Identify where player visibility range detection occurs
Locate title removal/cleanup logic
Implement fix to properly remove titles when players leave range
Test the implementation
Commit and push changes
Create pull request

Summary of Changes

Root Cause: The hologram cleanup logic in TraitTitle.kt had synchronization issues between the dual lookup maps (playerLookup and entityLookup) when players left the NPC's visible range.

Fix Applied: Enhanced the hologram management system in three key areas:

Improved remove() method (TraitTitle.kt:160-180):
- Added robust cleanup that handles both lookup maps independently
- Prevents null pointer exceptions with safe navigation
- Cleans up empty map containers to prevent memory leaks
Enhanced create() method (TraitTitle.kt:95-121):
- Ensures complete cleanup before creating new holograms
- Properly handles existing hologram instances that might cause duplication
- Added explicit cleanup of any old holograms during map updates
Strengthened player quit handler (TraitTitle.kt:75-87):
- Added safe navigation to prevent crashes
- Implemented proper cleanup of empty entity maps
- Prevents memory leaks when players disconnect

Testing: Code changes were validated for logical correctness and proper error handling.

npc头衔叠加问题 #110

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions