Skip to content

Commit 0fa8da7

Browse files
author
Taha Zahit Hakyemez
committed
Add BiMap.Tests project and enable unit testing in CI workflow
1 parent 8ce2398 commit 0fa8da7

File tree

5 files changed

+266
-25
lines changed

5 files changed

+266
-25
lines changed

‎.github/workflows/dotnet.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ jobs:
2121
run: dotnet restore BiMap.sln
2222
- name: Build
2323
run: dotnet build --no-restore BiMap.sln --configuration Release
24+
- name: Test
25+
run: dotnet test --no-build BiMap.sln --configuration Release
2426
- name: Pack
2527
run: dotnet pack BiMap/BiMap.csproj --configuration Release --output nuget-packages
2628
- name: Upload NuGet Package

‎BiMap.Tests/BiMap.Tests.csproj‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
<Project Sdk="Microsoft.NET.Sdk">
2+
3+
<PropertyGroup>
4+
<TargetFramework>net10.0</TargetFramework>
5+
<ImplicitUsings>enable</ImplicitUsings>
6+
<Nullable>enable</Nullable>
7+
<IsPackable>false</IsPackable>
8+
</PropertyGroup>
9+
10+
<ItemGroup>
11+
<PackageReference Include="coverlet.collector" Version="6.0.4" />
12+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
13+
<PackageReference Include="xunit" Version="2.9.3" />
14+
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.4" />
15+
</ItemGroup>
16+
17+
<ItemGroup>
18+
<Using Include="Xunit" />
19+
</ItemGroup>
20+
21+
<ItemGroup>
22+
<ProjectReference Include="..\BiMap\BiMap.csproj" />
23+
</ItemGroup>
24+
25+
</Project>

‎BiMap.Tests/ConcurrencyTests.cs‎

Lines changed: 88 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,88 @@
1+
using System;
2+
using System.Collections.Generic;
3+
using System.Threading;
4+
using System.Threading.Tasks;
5+
using BiMap;
6+
using Xunit;
7+
8+
namespace BiMap.Tests
9+
{
10+
public class ConcurrencyTests
11+
{
12+
[Fact]
13+
public async Task Parallel_Add_ShouldBeThreadSafe()
14+
{
15+
var map = new BiMap<int, string>();
16+
int threadCount = 10;
17+
int itemsPerThread = 1000;
18+
19+
var tasks = new Task[threadCount];
20+
for (int i = 0; i < threadCount; i++)
21+
{
22+
int threadId = i;
23+
tasks[i] = Task.Run(() =>
24+
{
25+
for (int j = 0; j < itemsPerThread; j++)
26+
{
27+
int key = (threadId * itemsPerThread) + j;
28+
map.Add(key, key.ToString());
29+
}
30+
});
31+
}
32+
33+
await Task.WhenAll(tasks);
34+
35+
Assert.Equal(threadCount * itemsPerThread, map.Count);
36+
}
37+
38+
[Fact]
39+
public async Task Parallel_Read_And_Write_ShouldNotCrash()
40+
{
41+
var map = new BiMap<int, int>();
42+
bool running = true;
43+
44+
// Writer task
45+
var writer = Task.Run(async () =>
46+
{
47+
int key = 0;
48+
while (running)
49+
{
50+
map.Add(key, key * 10);
51+
map.RemoveByLeft(key);
52+
key++;
53+
if (key > 100000) key = 0;
54+
await Task.Yield();
55+
}
56+
});
57+
58+
// Reader tasks
59+
var readers = new Task[4];
60+
for (int i = 0; i < 4; i++)
61+
{
62+
readers[i] = Task.Run(async () =>
63+
{
64+
while (running)
65+
{
66+
// Just access the map to stress the locks
67+
_ = map.Count;
68+
_ = map.ContainsLeft(50);
69+
try
70+
{
71+
_ = map.EnumerateLeftToRight().ToList().Count;
72+
}
73+
catch { /* Ignore snapshotted errors during heavy churn if any (shouldn't be any with correct locks) */ }
74+
await Task.Yield();
75+
}
76+
});
77+
}
78+
79+
await Task.Delay(2000); // Run for 2 seconds
80+
running = false;
81+
await Task.WhenAll(writer);
82+
await Task.WhenAll(readers);
83+
84+
// Should exit cleanly without exceptions
85+
Assert.True(true);
86+
}
87+
}
88+
}

‎BiMap.Tests/CoreFunctionalityTests.cs‎

Lines changed: 100 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,100 @@
1+
using System;
2+
using System.Collections.Generic;
3+
using System.Linq;
4+
using BiMap;
5+
using Xunit;
6+
7+
namespace BiMap.Tests
8+
{
9+
public class CoreFunctionalityTests
10+
{
11+
[Fact]
12+
public void Add_ShouldAddKeyAndValue_WhenNotExists()
13+
{
14+
var map = new BiMap<int, string>();
15+
bool added = map.Add(1, "One");
16+
17+
Assert.True(added);
18+
Assert.Equal("One", map.GetLeftToRight(1));
19+
Assert.Equal(1, map.GetRightToLeft("One"));
20+
}
21+
22+
[Fact]
23+
public void Add_ShouldReturnFalse_WhenKeyExists()
24+
{
25+
var map = new BiMap<int, string>();
26+
map.Add(1, "One");
27+
28+
bool added = map.Add(1, "Uno"); // Duplicate Left
29+
Assert.False(added);
30+
Assert.Equal("One", map.GetLeftToRight(1));
31+
}
32+
33+
[Fact]
34+
public void Add_ShouldReturnFalse_WhenValueExists()
35+
{
36+
var map = new BiMap<int, string>();
37+
map.Add(1, "One");
38+
39+
bool added = map.Add(2, "One"); // Duplicate Right
40+
Assert.False(added);
41+
Assert.False(map.ContainsLeft(2));
42+
}
43+
44+
[Fact]
45+
public void RemoveByLeft_ShouldRemoveBothSides()
46+
{
47+
var map = new BiMap<int, string>();
48+
map.Add(1, "One");
49+
50+
bool removed = map.RemoveByLeft(1);
51+
52+
Assert.True(removed);
53+
Assert.False(map.ContainsLeft(1));
54+
Assert.False(map.ContainsRight("One"));
55+
Assert.Equal(0, map.Count);
56+
}
57+
58+
[Fact]
59+
public void RemoveByRight_ShouldRemoveBothSides()
60+
{
61+
var map = new BiMap<int, string>();
62+
map.Add(1, "One");
63+
64+
bool removed = map.RemoveByRight("One");
65+
66+
Assert.True(removed);
67+
Assert.False(map.ContainsLeft(1));
68+
Assert.False(map.ContainsRight("One"));
69+
Assert.Equal(0, map.Count);
70+
}
71+
72+
[Fact]
73+
public void Clear_ShouldRemoveAllItems()
74+
{
75+
var map = new BiMap<int, string>();
76+
map.Add(1, "One");
77+
map.Add(2, "Two");
78+
79+
map.Clear();
80+
81+
Assert.Equal(0, map.Count);
82+
Assert.False(map.ContainsLeft(1));
83+
Assert.False(map.ContainsRight("One"));
84+
}
85+
86+
[Fact]
87+
public void Enumerate_ShouldReturnAllItems()
88+
{
89+
var map = new BiMap<int, string>();
90+
map.Add(1, "One");
91+
map.Add(2, "Two");
92+
93+
var items = map.EnumerateLeftToRight().ToList();
94+
95+
Assert.Equal(2, items.Count);
96+
Assert.Contains(items, kv => kv.Key == 1 && kv.Value == "One");
97+
Assert.Contains(items, kv => kv.Key == 2 && kv.Value == "Two");
98+
}
99+
}
100+
}

‎BiMap.sln‎

Lines changed: 51 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,51 @@
1-
2-
Microsoft Visual Studio Solution File, Format Version 12.00
3-
# Visual Studio Version 16
4-
VisualStudioVersion = 16.0.29123.88
5-
MinimumVisualStudioVersion = 10.0.40219.1
6-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "BiMap", "BiMap\BiMap.csproj", "{019225E0-80C3-4874-A649-C361F88453D4}"
7-
EndProject
8-
Global
9-
GlobalSection(SolutionConfigurationPlatforms) = preSolution
10-
Debug|Any CPU = Debug|Any CPU
11-
Release|Any CPU = Release|Any CPU
12-
EndGlobalSection
13-
GlobalSection(ProjectConfigurationPlatforms) = postSolution
14-
{019225E0-80C3-4874-A649-C361F88453D4}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
15-
{019225E0-80C3-4874-A649-C361F88453D4}.Debug|Any CPU.Build.0 = Debug|Any CPU
16-
{019225E0-80C3-4874-A649-C361F88453D4}.Release|Any CPU.ActiveCfg = Release|Any CPU
17-
{019225E0-80C3-4874-A649-C361F88453D4}.Release|Any CPU.Build.0 = Release|Any CPU
18-
EndGlobalSection
19-
GlobalSection(SolutionProperties) = preSolution
20-
HideSolutionNode = FALSE
21-
EndGlobalSection
22-
GlobalSection(ExtensibilityGlobals) = postSolution
23-
SolutionGuid = {4E763E06-63C1-436B-9C2E-946FF6CD67CF}
24-
EndGlobalSection
25-
EndGlobal
1+
2+
Microsoft Visual Studio Solution File, Format Version 12.00
3+
# Visual Studio Version 16
4+
VisualStudioVersion = 16.0.29123.88
5+
MinimumVisualStudioVersion = 10.0.40219.1
6+
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "BiMap", "BiMap\BiMap.csproj", "{019225E0-80C3-4874-A649-C361F88453D4}"
7+
EndProject
8+
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "BiMap.Tests", "BiMap.Tests\BiMap.Tests.csproj", "{9772F9F9-AC48-4CA0-9073-449875C0CEB2}"
9+
EndProject
10+
Global
11+
GlobalSection(SolutionConfigurationPlatforms) = preSolution
12+
Debug|Any CPU = Debug|Any CPU
13+
Debug|x64 = Debug|x64
14+
Debug|x86 = Debug|x86
15+
Release|Any CPU = Release|Any CPU
16+
Release|x64 = Release|x64
17+
Release|x86 = Release|x86
18+
EndGlobalSection
19+
GlobalSection(ProjectConfigurationPlatforms) = postSolution
20+
{019225E0-80C3-4874-A649-C361F88453D4}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
21+
{019225E0-80C3-4874-A649-C361F88453D4}.Debug|Any CPU.Build.0 = Debug|Any CPU
22+
{019225E0-80C3-4874-A649-C361F88453D4}.Debug|x64.ActiveCfg = Debug|Any CPU
23+
{019225E0-80C3-4874-A649-C361F88453D4}.Debug|x64.Build.0 = Debug|Any CPU
24+
{019225E0-80C3-4874-A649-C361F88453D4}.Debug|x86.ActiveCfg = Debug|Any CPU
25+
{019225E0-80C3-4874-A649-C361F88453D4}.Debug|x86.Build.0 = Debug|Any CPU
26+
{019225E0-80C3-4874-A649-C361F88453D4}.Release|Any CPU.ActiveCfg = Release|Any CPU
27+
{019225E0-80C3-4874-A649-C361F88453D4}.Release|Any CPU.Build.0 = Release|Any CPU
28+
{019225E0-80C3-4874-A649-C361F88453D4}.Release|x64.ActiveCfg = Release|Any CPU
29+
{019225E0-80C3-4874-A649-C361F88453D4}.Release|x64.Build.0 = Release|Any CPU
30+
{019225E0-80C3-4874-A649-C361F88453D4}.Release|x86.ActiveCfg = Release|Any CPU
31+
{019225E0-80C3-4874-A649-C361F88453D4}.Release|x86.Build.0 = Release|Any CPU
32+
{9772F9F9-AC48-4CA0-9073-449875C0CEB2}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
33+
{9772F9F9-AC48-4CA0-9073-449875C0CEB2}.Debug|Any CPU.Build.0 = Debug|Any CPU
34+
{9772F9F9-AC48-4CA0-9073-449875C0CEB2}.Debug|x64.ActiveCfg = Debug|Any CPU
35+
{9772F9F9-AC48-4CA0-9073-449875C0CEB2}.Debug|x64.Build.0 = Debug|Any CPU
36+
{9772F9F9-AC48-4CA0-9073-449875C0CEB2}.Debug|x86.ActiveCfg = Debug|Any CPU
37+
{9772F9F9-AC48-4CA0-9073-449875C0CEB2}.Debug|x86.Build.0 = Debug|Any CPU
38+
{9772F9F9-AC48-4CA0-9073-449875C0CEB2}.Release|Any CPU.ActiveCfg = Release|Any CPU
39+
{9772F9F9-AC48-4CA0-9073-449875C0CEB2}.Release|Any CPU.Build.0 = Release|Any CPU
40+
{9772F9F9-AC48-4CA0-9073-449875C0CEB2}.Release|x64.ActiveCfg = Release|Any CPU
41+
{9772F9F9-AC48-4CA0-9073-449875C0CEB2}.Release|x64.Build.0 = Release|Any CPU
42+
{9772F9F9-AC48-4CA0-9073-449875C0CEB2}.Release|x86.ActiveCfg = Release|Any CPU
43+
{9772F9F9-AC48-4CA0-9073-449875C0CEB2}.Release|x86.Build.0 = Release|Any CPU
44+
EndGlobalSection
45+
GlobalSection(SolutionProperties) = preSolution
46+
HideSolutionNode = FALSE
47+
EndGlobalSection
48+
GlobalSection(ExtensibilityGlobals) = postSolution
49+
SolutionGuid = {4E763E06-63C1-436B-9C2E-946FF6CD67CF}
50+
EndGlobalSection
51+
EndGlobal

0 commit comments

Comments
 (0)