Skip to content

Commit 95dc82e

Browse files
committed
misc refactor
1 parent 461cc2c commit 95dc82e

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

src/main/java/io/github/tahanima/page/BasePage.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package io.github.tahanima.page;
22

3-
import static io.github.tahanima.config.ConfigurationManager.config;
4-
53
import com.microsoft.playwright.Page;
64

75
import io.qameta.allure.Step;
@@ -13,9 +11,8 @@ public class BasePage {
1311

1412
protected Page page;
1513

16-
public void setAndConfigurePage(Page page) {
14+
public void setPage(Page page) {
1715
this.page = page;
18-
page.setDefaultTimeout(config().timeout());
1916
}
2017

2118
@Step

src/main/java/io/github/tahanima/page/BasePageFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ private BasePageFactory() {}
1212
public static <T extends BasePage> T createInstance(Page page, Class<T> basePage) {
1313
try {
1414
BasePage instance = basePage.getDeclaredConstructor().newInstance();
15-
instance.setAndConfigurePage(page);
15+
instance.setPage(page);
1616

1717
return basePage.cast(instance);
1818
} catch (Exception e) {

src/test/java/io/github/tahanima/e2e/login/LoginE2ETest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import static com.microsoft.playwright.assertions.PlaywrightAssertions.assertThat;
44

5+
import static io.github.tahanima.config.ConfigurationManager.config;
6+
57
import io.github.tahanima.data.login.LoginTestData;
68
import io.github.tahanima.e2e.BaseE2ETest;
79
import io.github.tahanima.page.login.LoginPage;
@@ -25,6 +27,8 @@ class LoginE2ETest extends BaseE2ETest {
2527
public void createBrowserContextAndPageAndLoginPageInstances() {
2628
browserContext = browser.newContext();
2729
page = browserContext.newPage();
30+
31+
page.setDefaultTimeout(config().timeout());
2832

2933
loginPage = createInstance(LoginPage.class);
3034
}

0 commit comments

Comments
 (0)