Use POST method for creating new attachments instead of PUT

Author: matthijsln

src/main/java/org/tailormap/api/controller/AttachmentsController.java

@@ -17,7 +17,6 @@
 import java.util.Set;
 import java.util.UUID;
 import java.util.regex.Pattern;
-
 import org.geotools.api.data.Query;
 import org.geotools.api.data.SimpleFeatureSource;
 import org.geotools.api.filter.Filter;
@@ -36,7 +35,7 @@
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.ModelAttribute;
 import org.springframework.web.bind.annotation.PathVariable;
-import org.springframework.web.bind.annotation.PutMapping;
+import org.springframework.web.bind.annotation.PostMapping;
 import org.springframework.web.bind.annotation.RequestPart;
 import org.springframework.web.server.ResponseStatusException;
 import org.tailormap.api.annotation.AppRestController;
@@ -79,7 +78,7 @@ public AttachmentsController(EditUtil editUtil, FeatureSourceFactoryHelper featu
    * @param fileData the attachment file data
    * @return the response entity
    */
-  @PutMapping(
+  @PostMapping(
       path = {
         "${tailormap-api.base-path}/{viewerKind}/{viewerName}/layer/{appLayerId}/feature/{featureId}/attachments"
       },
@@ -151,7 +150,8 @@ public ResponseEntity<Serializable> addAttachment(
    * @return true if the file's extension or MIME type matches one of the accepted types, false otherwise
    */
   private static boolean validateMimeTypeAccept(String acceptList, String fileName, String mimeType) {
-    Iterable<String> allowedMimeTypes = Splitter.on(Pattern.compile(",\\s*")).split(acceptList);
+    Iterable<String> allowedMimeTypes =
+        Splitter.on(Pattern.compile(",\\s*")).split(acceptList);
     final Locale locale = Locale.ENGLISH;
     for (String allowedType : allowedMimeTypes) {
       if (allowedType.startsWith(".")) {

src/test/java/org/tailormap/api/controller/AttachmentsControllerIntegrationTest.java

@@ -120,7 +120,7 @@ void addAttachment(String url) throws Exception {
             .file(attachmentMetadata)
             .file(svgFile)
             .with(request -> {
-              request.setMethod("PUT");
+              request.setMethod("POST");
               return request;
             })
             .with(setServletPath(url))
@@ -150,7 +150,7 @@ void addAttachmentUnauthorised(String url) throws Exception {
             .file(attachmentMetadata)
             .file(svgFile)
             .with(request -> {
-              request.setMethod("PUT");
+              request.setMethod("POST");
               return request;
             })
             .with(setServletPath(url))
@@ -174,7 +174,7 @@ void addAttachmentsNotSupported() throws Exception {
             .file(attachmentMetadata)
             .file(svgFile)
             .with(request -> {
-              request.setMethod("PUT");
+              request.setMethod("POST");
               return request;
             })
             .with(setServletPath(url))
@@ -200,7 +200,7 @@ void addAttachmentsToNonEditableLayer() throws Exception {
             .file(attachmentMetadata)
             .file(svgFile)
             .with(request -> {
-              request.setMethod("PUT");
+              request.setMethod("POST");
               return request;
             })
             .with(setServletPath(url))