Simplify edit filters expanded input

Author: steinkobben

projects/core/src/lib/components/filter/edit-attribute-filters/edit-attribute-filters.component.html

@@ -1,4 +1,4 @@
-<mat-expansion-panel class="edit-filter-expansion-panel" [expanded]="onlyGroupInListOnInit()">
+<mat-expansion-panel class="edit-filter-expansion-panel" [expanded]="expanded()">
   <mat-expansion-panel-header i18n="@@core.filter.edit-filters">Edit filters</mat-expansion-panel-header>
   @for (filter of editableFilters(); track filter.id) {
     <div class="edit-attribute-filters">

projects/core/src/lib/components/filter/edit-attribute-filters/edit-attribute-filters.component.ts

@@ -26,7 +26,7 @@ export class EditAttributeFiltersComponent {
   public editableFilters = input<AttributeFilterModel[]>([]);
   public filterGroupId = input<string | null>(null);
   public layerIds = input<string[]>([]);
-  public onlyGroupInListOnInit = input<boolean>(false);
+  public expanded = input<boolean>(false);
 
   public isSliderFilter(filter: AttributeFilterModel): boolean {
     return filter.editConfiguration?.filterTool === FilterToolEnum.SLIDER;

projects/core/src/lib/components/filter/filter-list-item/filter-list-item.component.html

@@ -25,7 +25,7 @@
           [editableFilters]="editableFilters"
           [filterGroupId]="filter.id"
           [layerIds]="filter.layerIds"
-          [onlyGroupInListOnInit]="onlyGroupInListOnInit"></tm-edit-attribute-filter>
+          [expanded]="editFiltersExpanded"></tm-edit-attribute-filter>
       </div>
     }
     <mat-card-actions align="end">

projects/core/src/lib/components/filter/filter-list-item/filter-list-item.component.ts

@@ -31,7 +31,7 @@ export class FilterListItemComponent {
   }
 
   @Input()
-  public onlyGroupInListOnInit = false;
+  public editFiltersExpanded = false;
 
   private store$ = inject(Store);
   private removeFilterService = inject(RemoveFilterService);

projects/core/src/lib/components/filter/filter-list/filter-list.component.html

@@ -1,3 +1,4 @@
-@for (filter of (filters$ | async); track filter.id) {
-  <tm-filter-list-item [filterGroup]="filter" [onlyGroupInListOnInit]="onlyGroupInListOnInit"></tm-filter-list-item>
+@let filters = filters$ | async;
+@for (filter of filters; track filter.id) {
+  <tm-filter-list-item [filterGroup]="filter" [editFiltersExpanded]="filters?.length === 1"></tm-filter-list-item>
 }

projects/core/src/lib/components/filter/filter-list/filter-list.component.ts

@@ -1,7 +1,7 @@
 import { Component, OnInit, ChangeDetectionStrategy, inject } from '@angular/core';
 import { Store } from '@ngrx/store';
 import { selectFilterGroupsWithLayers } from '../../../state/filter-state/filter.selectors';
-import { map, Observable, of, take } from 'rxjs';
+import { Observable, of } from 'rxjs';
 import { ExtendedFilterGroupModel } from '../../../filter/models/extended-filter-group.model';
 
 @Component({
@@ -15,15 +15,9 @@ export class FilterListComponent implements OnInit {
   private store$ = inject(Store);
 
   public filters$: Observable<ExtendedFilterGroupModel[]> = of([]);
-  public onlyGroupInListOnInit: boolean = false;
 
   public ngOnInit(): void {
     this.filters$ = this.store$.select(selectFilterGroupsWithLayers);
-
-    this.filters$.pipe(
-      take(1),
-      map(groups => groups.length === 1),
-    ).subscribe(onlyGroupInList => this.onlyGroupInListOnInit = onlyGroupInList);
   }
 
 }