Address review comments

Author: matthijsln

projects/core/src/lib/components/edit/edit/edit.component.ts

@@ -104,7 +104,7 @@ export class EditComponent implements OnInit {
       this.mapService.getMapViewDetails$() ]).pipe(
       takeUntilDestroyed(this.destroyRef),
     ).subscribe(([ selectedEditLayerId, visibleLayers, mapViewDetails ]) => {
-      const layers = selectedEditLayerId == null ? [] : visibleLayers.filter(layer =>
+      const layers = selectedEditLayerId === null ? [] : visibleLayers.filter(layer =>
         layer.id !== selectedEditLayerId
         && ScaleHelper.isInScale(mapViewDetails.scale, layer.minScale, layer.maxScale)
         && this.selectedCopyLayerIds.length == 0 || this.selectedCopyLayerIds.includes(layer.id));
@@ -190,7 +190,7 @@ export class EditComponent implements OnInit {
   public createFeatureFromLayer(id: string) {
 
     this.selectedCopyLayer$.pipe(take(1)).subscribe(selectedCopyLayer => {
-      if (id == selectedCopyLayer) {
+      if (id === selectedCopyLayer) {
         this.store$.dispatch(setEditCopyOtherLayerFeaturesDisabled());
         return;
       }

projects/core/src/lib/components/edit/state/edit.reducer.ts

@@ -80,12 +80,13 @@ const onLoadCopyFeaturesSuccess = (
     return state;
   }
 
-  // Deselect a feature by checking if the geometry WKT is already in the copiedFeatures array (can't search by fid)
+  // Deselect a feature by checking if the geometry WKT is already in the copiedFeatures array.
+  // We can't deselect by checking the FID, because WMS GetFeatureInfo responses have a different FID every time (generated by us), and we
+  // want to have this work for WMS GFI responses as well.
   const sameGeometryIndex = state.copiedFeatures.findIndex(f => f.geometry === geometry);
   const copiedFeatures = sameGeometryIndex !== -1
-    ? state.copiedFeatures.filter((_, idx) => idx !== sameGeometryIndex)
+    ? [ ...state.copiedFeatures.slice(0, sameGeometryIndex), ...state.copiedFeatures.slice(sameGeometryIndex + 1) ]
     : [ ...state.copiedFeatures, payload.featureInfo[0].features[0] ];
-
   return {
     ...state,
     copiedFeatures,