do not inject AttributeFilterHelper in tests

Author: steinkobben

projects/core/src/lib/components/filter/filter-list/filter-list.component.spec.ts

@@ -8,15 +8,10 @@ import { FilterListItemComponent } from '../filter-list-item/filter-list-item.co
 import { selectFilterGroupsWithLayers } from '../../../state/filter-state/filter.selectors';
 import { MatIconTestingModule } from '@angular/material/icon/testing';
 import { FilterDescriptionComponent } from '../../../filter/filter-description/filter-description.component';
-import { AttributeFilterHelper } from '../../../filter/helpers/attribute-filter.helper';
-import { of } from 'rxjs';
 
 describe('FilterListComponent', () => {
 
   test('should render empty list', async () => {
-    const mockAttributeFilterService = {
-      addAttributeAliasesToFilters$: jest.fn().mockImplementation((filterGroups) => of(filterGroups)),
-    };
     await render(FilterListComponent, {
       imports: [ SharedImportsModule, MatIconTestingModule ],
       declarations: [ FilterListItemComponent, FilterDescriptionComponent ],
@@ -34,17 +29,13 @@ describe('FilterListComponent', () => {
             },
           ],
         }),
-        { provide: AttributeFilterHelper, useValue: mockAttributeFilterService },
       ],
     });
     expect(screen.queryByText('Attribute filter')).not.toBeInTheDocument();
     expect(screen.queryByTestId('filter-list-item')).toBeNull();
   });
 
   test('should render list with filters', async () => {
-    const mockAttributeFilterService = {
-      addAttributeAliasesToFilters$: jest.fn().mockImplementation((filterGroups) => of(filterGroups)),
-    };
     const store = provideMockStore({
       initialState: {},
       selectors: [
@@ -57,10 +48,7 @@ describe('FilterListComponent', () => {
       ],
     });
     await render(FilterListComponent, {
-      providers: [
-        store,
-        { provide: AttributeFilterHelper, useValue: mockAttributeFilterService },
-      ],
+      providers: [store],
       declarations: [ FilterListItemComponent, FilterDescriptionComponent ],
       imports: [ SharedImportsModule, MatIconTestingModule ],
     });

projects/core/src/lib/state/core.effects.spec.ts

@@ -3,21 +3,17 @@ import { TestBed } from '@angular/core/testing';
 import { provideMockActions } from '@ngrx/effects/testing';
 import { Observable, of } from 'rxjs';
 import { LoadViewerService } from '../services/load-viewer.service';
-import { AttributeFilterModel, FilterGroupModel, getViewerResponseData } from '@tailormap-viewer/api';
+import { getViewerResponseData } from '@tailormap-viewer/api';
 import { Location } from '@angular/common';
 import { Router } from '@angular/router';
 import * as CoreActions from './core.actions';
-import { AttributeFilterHelper } from '../filter/helpers/attribute-filter.helper';
 
 describe('CoreEffects', () => {
 
   const setup = (currentPath: string, actions$: Observable<any>): [ CoreEffects, jest.Mock ] => {
     const loadViewerServiceMock = {
       loadViewer$: () => of({ success: true, result: { viewer: getViewerResponseData(), components: [] } }),
     };
-    const attributeFilterServiceMock = {
-      disableFiltersForMissingAttributes$: (filterGroups: FilterGroupModel<AttributeFilterModel>[]) => of(filterGroups),
-    };
     const locationMock = {
       path: () => currentPath,
     };
@@ -32,7 +28,6 @@ describe('CoreEffects', () => {
         { provide: LoadViewerService, useValue: loadViewerServiceMock },
         { provide: Location, useValue: locationMock },
         { provide: Router, useValue: routerMock },
-        { provide: AttributeFilterHelper, useValue: attributeFilterServiceMock },
       ],
     });
     const effects = TestBed.inject(CoreEffects);