Skip to content

Commit faa9f3f

Browse files
committed
fix(button): Take account pr fix to release new version. Use span inside button. Styling fixes.
1 parent 347c23c commit faa9f3f

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/Button.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ const ButtonWrapper = styled.button`
102102
}
103103
`;
104104

105-
const ButtonContent = withRipple(styled.div`
105+
const ButtonContent = withRipple(styled.span`
106106
display: flex;
107107
flex-direction: row;
108108
align-items: center;
@@ -126,14 +126,16 @@ const rippleStyles = {
126126
const Button = ({ children, ...rest }) => {
127127
const { disabled, small, large, className } = rest;
128128
return (
129-
<ButtonWrapper {...rest}
130-
>
131-
<ButtonContent {...{ disabled, small, large, className }} wrapperStyles={rippleStyles}>
129+
<ButtonWrapper {...rest}>
130+
<ButtonContent
131+
{...{ disabled, small, large, className }}
132+
wrapperStyles={rippleStyles}
133+
>
132134
{children}
133135
</ButtonContent>
134136
</ButtonWrapper>
135137
);
136-
}
138+
};
137139

138140
Button.propTypes = {
139141
children: PropTypes.any,

0 commit comments

Comments
 (0)