Fixed checkstyle

Author: merlimat

bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AddCompletion.java

@@ -23,6 +23,7 @@
 
 import io.netty.util.Recycler;
 import org.apache.bookkeeper.client.BKException;
+import org.apache.bookkeeper.common.util.MathUtils;
 import org.apache.bookkeeper.net.BookieId;
 import org.slf4j.MDC;
 
@@ -88,8 +89,7 @@ public void writeComplete(int rc, long ledgerId, long entryId,
 
     @Override
     boolean maybeTimeout() {
-        if (org.apache.bookkeeper.common.util.MathUtils.elapsedNanos(startTime) >=
-                perChannelBookieClient.addEntryTimeoutNanos) {
+        if (MathUtils.elapsedNanos(startTime) >= perChannelBookieClient.addEntryTimeoutNanos) {
             timeout();
             return true;
         } else {

bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BatchedReadCompletion.java

@@ -21,11 +21,10 @@
 
 package org.apache.bookkeeper.proto;
 
+import static org.apache.bookkeeper.client.LedgerHandle.INVALID_ENTRY_ID;
 import org.apache.bookkeeper.client.BKException;
 import org.apache.bookkeeper.util.ByteBufList;
 
-import static org.apache.bookkeeper.client.LedgerHandle.INVALID_ENTRY_ID;
-
 class BatchedReadCompletion extends CompletionValue {
 
     final BookkeeperInternalCallbacks.BatchedReadEntryCallback cb;
@@ -38,20 +37,12 @@ public BatchedReadCompletion(final CompletionKey key,
         super("BatchedRead", originalCtx, ledgerId, entryId, perChannelBookieClient);
         this.opLogger = perChannelBookieClient.readEntryOpLogger;
         this.timeoutOpLogger = perChannelBookieClient.readTimeoutOpLogger;
-        this.cb = new BookkeeperInternalCallbacks.BatchedReadEntryCallback() {
-
-            @Override
-            public void readEntriesComplete(int rc,
-                                            long ledgerId,
-                                            long startEntryId,
-                                            ByteBufList bufList,
-                                            Object ctx) {
-                logOpResult(rc);
-                originalCallback.readEntriesComplete(rc,
-                        ledgerId, entryId,
-                        bufList, originalCtx);
-                key.release();
-            }
+        this.cb = (rc, ledgerId1, startEntryId, bufList, ctx) -> {
+            logOpResult(rc);
+            originalCallback.readEntriesComplete(rc,
+                    ledgerId1, entryId,
+                    bufList, originalCtx);
+            key.release();
         };
     }
 

bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/CompletionValue.java

@@ -23,6 +23,8 @@
 
 import com.google.common.base.Joiner;
 import io.netty.channel.Channel;
+import java.util.Map;
+import java.util.concurrent.TimeUnit;
 import org.apache.bookkeeper.client.BKException;
 import org.apache.bookkeeper.common.util.MathUtils;
 import org.apache.bookkeeper.common.util.MdcUtils;
@@ -31,9 +33,6 @@
 import org.slf4j.LoggerFactory;
 import org.slf4j.MDC;
 
-import java.util.Map;
-import java.util.concurrent.TimeUnit;
-
 abstract class CompletionValue {
     private final String operationName;
     protected Object ctx;

bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ForceLedgerCompletion.java

@@ -22,7 +22,6 @@
 package org.apache.bookkeeper.proto;
 
 import org.apache.bookkeeper.client.BKException;
-import org.apache.bookkeeper.net.BookieId;
 
 class ForceLedgerCompletion extends CompletionValue {
     final BookkeeperInternalCallbacks.ForceLedgerCallback cb;

bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/GetListOfEntriesOfLedgerCompletion.java

@@ -21,6 +21,7 @@
 
 package org.apache.bookkeeper.proto;
 
+import static org.apache.bookkeeper.proto.BookkeeperInternalCallbacks.GetListOfEntriesOfLedgerCallback;
 import io.netty.buffer.ByteBuf;
 import io.netty.buffer.Unpooled;
 import org.apache.bookkeeper.client.BKException;
@@ -30,20 +31,16 @@ class GetListOfEntriesOfLedgerCompletion extends CompletionValue {
     final BookkeeperInternalCallbacks.GetListOfEntriesOfLedgerCallback cb;
 
     public GetListOfEntriesOfLedgerCompletion(final CompletionKey key,
-                                              final BookkeeperInternalCallbacks.GetListOfEntriesOfLedgerCallback origCallback,
+                                              final GetListOfEntriesOfLedgerCallback origCallback,
                                               final long ledgerId,
                                               PerChannelBookieClient perChannelBookieClient) {
         super("GetListOfEntriesOfLedger", null, ledgerId, 0L, perChannelBookieClient);
         this.opLogger = perChannelBookieClient.getListOfEntriesOfLedgerCompletionOpLogger;
         this.timeoutOpLogger = perChannelBookieClient.getListOfEntriesOfLedgerCompletionTimeoutOpLogger;
-        this.cb = new BookkeeperInternalCallbacks.GetListOfEntriesOfLedgerCallback() {
-            @Override
-            public void getListOfEntriesOfLedgerComplete(int rc, long ledgerId,
-                                                         AvailabilityOfEntriesOfLedger availabilityOfEntriesOfLedger) {
-                logOpResult(rc);
-                origCallback.getListOfEntriesOfLedgerComplete(rc, ledgerId, availabilityOfEntriesOfLedger);
-                key.release();
-            }
+        this.cb = (rc, ledgerId1, availabilityOfEntriesOfLedger) -> {
+            logOpResult(rc);
+            origCallback.getListOfEntriesOfLedgerComplete(rc, ledgerId1, availabilityOfEntriesOfLedger);
+            key.release();
         };
     }
 
@@ -62,8 +59,9 @@ public void handleV3Response(BookkeeperProtocol.Response response) {
         BookkeeperProtocol.GetListOfEntriesOfLedgerResponse getListOfEntriesOfLedgerResponse = response
                 .getGetListOfEntriesOfLedgerResponse();
         ByteBuf availabilityOfEntriesOfLedgerBuffer = Unpooled.EMPTY_BUFFER;
-        BookkeeperProtocol.StatusCode status = response.getStatus() == BookkeeperProtocol.StatusCode.EOK ? getListOfEntriesOfLedgerResponse.getStatus()
-                : response.getStatus();
+        BookkeeperProtocol.StatusCode status =
+                response.getStatus() == BookkeeperProtocol.StatusCode.EOK ? getListOfEntriesOfLedgerResponse.getStatus()
+                        : response.getStatus();
 
         if (getListOfEntriesOfLedgerResponse.hasAvailabilityOfEntriesOfLedger()) {
             availabilityOfEntriesOfLedgerBuffer = Unpooled.wrappedBuffer(

bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java

@@ -18,17 +18,13 @@
  */
 package org.apache.bookkeeper.proto;
 
-import static org.apache.bookkeeper.client.LedgerHandle.INVALID_ENTRY_ID;
-
-import com.google.common.base.Joiner;
 import com.google.common.collect.Sets;
 import com.google.protobuf.ByteString;
 import com.google.protobuf.ExtensionRegistry;
 import com.google.protobuf.UnsafeByteOperations;
 import io.netty.bootstrap.Bootstrap;
 import io.netty.buffer.ByteBuf;
 import io.netty.buffer.ByteBufAllocator;
-import io.netty.buffer.Unpooled;
 import io.netty.buffer.UnpooledByteBufAllocator;
 import io.netty.channel.Channel;
 import io.netty.channel.ChannelFuture;
@@ -61,7 +57,6 @@
 import io.netty.incubator.channel.uring.IOUringSocketChannel;
 import io.netty.util.Recycler;
 import io.netty.util.Recycler.Handle;
-import io.netty.util.ReferenceCountUtil;
 import io.netty.util.ReferenceCounted;
 import io.netty.util.concurrent.Future;
 import io.netty.util.concurrent.GenericFutureListener;
@@ -95,7 +90,6 @@
 import org.apache.bookkeeper.auth.ClientAuthProvider;
 import org.apache.bookkeeper.client.BKException;
 import org.apache.bookkeeper.client.BookKeeperClientStats;
-import org.apache.bookkeeper.client.BookieInfoReader.BookieInfo;
 import org.apache.bookkeeper.client.api.WriteFlag;
 import org.apache.bookkeeper.common.util.MathUtils;
 import org.apache.bookkeeper.common.util.MdcUtils;
@@ -109,31 +103,22 @@
 import org.apache.bookkeeper.proto.BookkeeperInternalCallbacks.GetBookieInfoCallback;
 import org.apache.bookkeeper.proto.BookkeeperInternalCallbacks.GetListOfEntriesOfLedgerCallback;
 import org.apache.bookkeeper.proto.BookkeeperInternalCallbacks.ReadEntryCallback;
-import org.apache.bookkeeper.proto.BookkeeperInternalCallbacks.ReadEntryCallbackCtx;
 import org.apache.bookkeeper.proto.BookkeeperInternalCallbacks.ReadLacCallback;
-import org.apache.bookkeeper.proto.BookkeeperInternalCallbacks.StartTLSCallback;
 import org.apache.bookkeeper.proto.BookkeeperInternalCallbacks.WriteCallback;
 import org.apache.bookkeeper.proto.BookkeeperInternalCallbacks.WriteLacCallback;
 import org.apache.bookkeeper.proto.BookkeeperProtocol.AddRequest;
-import org.apache.bookkeeper.proto.BookkeeperProtocol.AddResponse;
 import org.apache.bookkeeper.proto.BookkeeperProtocol.BKPacketHeader;
 import org.apache.bookkeeper.proto.BookkeeperProtocol.ForceLedgerRequest;
-import org.apache.bookkeeper.proto.BookkeeperProtocol.ForceLedgerResponse;
 import org.apache.bookkeeper.proto.BookkeeperProtocol.GetBookieInfoRequest;
-import org.apache.bookkeeper.proto.BookkeeperProtocol.GetBookieInfoResponse;
 import org.apache.bookkeeper.proto.BookkeeperProtocol.GetListOfEntriesOfLedgerRequest;
-import org.apache.bookkeeper.proto.BookkeeperProtocol.GetListOfEntriesOfLedgerResponse;
 import org.apache.bookkeeper.proto.BookkeeperProtocol.OperationType;
 import org.apache.bookkeeper.proto.BookkeeperProtocol.ProtocolVersion;
 import org.apache.bookkeeper.proto.BookkeeperProtocol.ReadLacRequest;
-import org.apache.bookkeeper.proto.BookkeeperProtocol.ReadLacResponse;
 import org.apache.bookkeeper.proto.BookkeeperProtocol.ReadRequest;
-import org.apache.bookkeeper.proto.BookkeeperProtocol.ReadResponse;
 import org.apache.bookkeeper.proto.BookkeeperProtocol.Request;
 import org.apache.bookkeeper.proto.BookkeeperProtocol.Response;
 import org.apache.bookkeeper.proto.BookkeeperProtocol.StatusCode;
 import org.apache.bookkeeper.proto.BookkeeperProtocol.WriteLacRequest;
-import org.apache.bookkeeper.proto.BookkeeperProtocol.WriteLacResponse;
 import org.apache.bookkeeper.stats.Counter;
 import org.apache.bookkeeper.stats.NullStatsLogger;
 import org.apache.bookkeeper.stats.OpStatsLogger;
@@ -142,7 +127,6 @@
 import org.apache.bookkeeper.tls.SecurityException;
 import org.apache.bookkeeper.tls.SecurityHandlerFactory;
 import org.apache.bookkeeper.tls.SecurityHandlerFactory.NodeType;
-import org.apache.bookkeeper.util.AvailabilityOfEntriesOfLedger;
 import org.apache.bookkeeper.util.ByteBufList;
 import org.apache.bookkeeper.util.StringUtils;
 import org.apache.bookkeeper.util.collections.ConcurrentOpenHashMap;

bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadCompletion.java

@@ -21,13 +21,12 @@
 
 package org.apache.bookkeeper.proto;
 
+import static org.apache.bookkeeper.client.LedgerHandle.INVALID_ENTRY_ID;
 import io.netty.buffer.ByteBuf;
 import io.netty.buffer.Unpooled;
 import io.netty.util.ReferenceCountUtil;
 import org.apache.bookkeeper.client.BKException;
 
-import static org.apache.bookkeeper.client.LedgerHandle.INVALID_ENTRY_ID;
-
 class ReadCompletion extends CompletionValue {
     final BookkeeperInternalCallbacks.ReadEntryCallback cb;