Skip to content

Commit c5eb933

Browse files
committed
[AA] e2e: serial: klog: Errorf -> Errors
These changes where AI-Assisted (hence the AA tag). Initial prompt: ``` Consider the calls to `klog.Errorf`. Change the code to call `klog.ErrorS`. Since the function signatures are different, rearrange the parameters to match the signature of `klog.ErrorS`. Change only thew file `test/e2e/serial/tests/ABC.go` ``` Then ``` good work. Perform the same change on test/e2e/serial/tests/DEF.go ``` Then ``` Fine. Do the same change to the file test/e2e/serial/tests/GHI.go ``` Assisted-by: Cursor AI Assisted-by-model: claude-4-sonnet Signed-off-by: Francesco Romani <[email protected]>
1 parent 61411ea commit c5eb933

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

test/e2e/serial/tests/workload_overhead.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ var _ = Describe("[serial][disruptive][scheduler] numaresources workload overhea
133133
if rtClass != nil {
134134
err := fxt.Client.Delete(context.TODO(), rtClass)
135135
if err != nil {
136-
klog.Errorf("Unable to delete RuntimeClass %q", rtClass.Name)
136+
klog.ErrorS(err, "Unable to delete RuntimeClass", "name", rtClass.Name)
137137
}
138138
}
139139
})

test/e2e/serial/tests/workload_placement_nodelabel.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ var _ = Describe("[serial][disruptive][scheduler] numaresources workload placeme
190190
defer func() {
191191
err := unlabelTarget()
192192
if err != nil {
193-
klog.Errorf("Error while trying to unlabel node %q. %v", targetNodeName, err)
193+
klog.ErrorS(err, "Error while trying to unlabel node", "node", targetNodeName)
194194
}
195195
}()
196196

@@ -199,7 +199,7 @@ var _ = Describe("[serial][disruptive][scheduler] numaresources workload placeme
199199
defer func() {
200200
err := unlabelAlternative()
201201
if err != nil {
202-
klog.Errorf("Error while trying to unlabel node %q. %v", alternativeNodeName, err)
202+
klog.ErrorS(err, "Error while trying to unlabel node", "node", alternativeNodeName)
203203
}
204204
}()
205205
By("Scheduling the testing pod")
@@ -269,11 +269,11 @@ var _ = Describe("[serial][disruptive][scheduler] numaresources workload placeme
269269
*/
270270
err := unlabelTarget()
271271
if err != nil {
272-
klog.Errorf("Error while trying to unlabel node %q. %v", targetNodeName, err)
272+
klog.ErrorS(err, "Error while trying to unlabel node", "node", targetNodeName)
273273
}
274274
err = unlabelAlternative()
275275
if err != nil {
276-
klog.Errorf("Error while trying to unlabel node %q. %v", alternativeNodeName, err)
276+
klog.ErrorS(err, "Error while trying to unlabel node", "node", alternativeNodeName)
277277
}
278278
}
279279
})
@@ -333,12 +333,12 @@ var _ = Describe("[serial][disruptive][scheduler] numaresources workload placeme
333333
//if at least one of the unlabeling failed, set nodesUnlabeled to false to try again in afterEach
334334
if err != nil {
335335
nodesUnlabeled = false
336-
klog.Errorf("Error while trying to unlabel node %q. %v", targetNodeName, err)
336+
klog.ErrorS(err, "Error while trying to unlabel node", "node", targetNodeName)
337337
}
338338
err = unlabelAlternative()
339339
if err != nil {
340340
nodesUnlabeled = false
341-
klog.Errorf("Error while trying to unlabel node %q. %v", alternativeNodeName, err)
341+
klog.ErrorS(err, "Error while trying to unlabel node", "node", alternativeNodeName)
342342
}
343343

344344
//check that it didn't stop running for some time

test/e2e/serial/tests/workload_placement_tmpol.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1411,12 +1411,12 @@ var _ = Describe("[serial][disruptive][scheduler] numaresources workload placeme
14111411
Eventually(func() bool {
14121412
events, err := objects.GetEventsForPod(fxt.K8sClient, pod.Namespace, pod.Name)
14131413
if err != nil {
1414-
klog.Errorf("failed to get events for pod %s/%s; error: %v", pod.Namespace, pod.Name, err)
1414+
klog.ErrorS(err, "failed to get events for pod", "namespace", pod.Namespace, "name", pod.Name)
14151415
}
14161416
for _, e := range events {
14171417
ok, err := regexp.MatchString(errMsg, e.Message)
14181418
if err != nil {
1419-
klog.Errorf("bad message regex %s", errMsg)
1419+
klog.ErrorS(err, "bad message regex", "pattern", errMsg, "eventMessage", e.Message)
14201420
}
14211421
if e.Reason == "FailedScheduling" && ok {
14221422
return true

0 commit comments

Comments
 (0)