NTFS: FileRecord: Use Segments for logging purposes

Author: TalAloni

DiskAccessLibrary/FileSystems/NTFS/FileRecord/FileRecord.cs

@@ -16,25 +16,40 @@ namespace DiskAccessLibrary.FileSystems.NTFS
     /// </summary>
     public class FileRecord
     {
-        private List<FileRecordSegment> m_segments;
+        private List<FileRecordSegment> m_segments; // Used for logging purposes and must not be modified outside UpdateSegments
+        
+        public ushort ReferenceCount;
+        public bool IsInUse;
+        public bool IsDirectory;
         private List<AttributeRecord> m_attributes;
 
         internal FileRecord(FileRecordSegment segment)
         {
             m_segments = new List<FileRecordSegment>();
             m_segments.Add(segment);
+
+            ReferenceCount = m_segments[0].ReferenceCount;
+            IsInUse = m_segments[0].IsInUse;
+            IsDirectory = m_segments[0].IsDirectory;
         }
 
         internal FileRecord(List<FileRecordSegment> segments)
         {
             m_segments = segments;
+
+            ReferenceCount = m_segments[0].ReferenceCount;
+            IsInUse = m_segments[0].IsInUse;
+            IsDirectory = m_segments[0].IsDirectory;
         }
 
         /// <remarks>
         /// https://blogs.technet.microsoft.com/askcore/2009/10/16/the-four-stages-of-ntfs-file-growth/
         /// </remarks>
         public void UpdateSegments(int bytesPerFileRecordSegment, byte minorNTFSVersion)
         {
+            m_segments[0].ReferenceCount = ReferenceCount;
+            m_segments[0].IsInUse = IsInUse;
+            m_segments[0].IsDirectory = IsDirectory;
             List<AttributeRecord> attributes = this.Attributes;
 
             foreach (FileRecordSegment segment in m_segments)
@@ -164,6 +179,9 @@ private FileNameRecord GetFileNameRecord(FileNameFlags fileNameNamespace)
             return null;
         }
 
+        /// <summary>
+        /// Used for logging purposes and must not be modified outside UpdateSegments
+        /// </summary>
         internal List<FileRecordSegment> Segments
         {
             get
@@ -172,6 +190,9 @@ internal List<FileRecordSegment> Segments
             }
         }
 
+        /// <summary>
+        /// Used for logging purposes and must not be modified outside UpdateSegments
+        /// </summary>
         internal FileRecordSegment BaseSegment
         {
             get
@@ -344,22 +365,6 @@ public AttributeRecord BitmapRecord
             }
         }
 
-        public bool IsInUse
-        {
-            get
-            {
-                return m_segments[0].IsInUse;
-            }
-        }
-
-        public bool IsDirectory
-        {
-            get
-            {
-                return m_segments[0].IsDirectory;
-            }
-        }
-
         public int AttributesLengthOnDisk
         {
             get

DiskAccessLibrary/FileSystems/NTFS/MasterFileTable.cs

@@ -281,7 +281,7 @@ public void UpdateFileRecord(FileRecord fileRecord, uint transactionID)
             Dictionary<MftSegmentReference, byte[]> undoDictionary = new Dictionary<MftSegmentReference, byte[]>();
             foreach (FileRecordSegment segment in fileRecord.Segments)
             {
-                byte[] segmentBytes = GetFileRecordSegment(segment.SegmentNumber).GetBytes(m_volume.BytesPerFileRecordSegment, m_volume.MinorVersion, false);
+                byte[] segmentBytes = segment.GetBytes(m_volume.BytesPerFileRecordSegment, m_volume.MinorVersion, false);
                 undoDictionary.Add(segment.SegmentReference, segmentBytes);
             }
 
@@ -397,11 +397,10 @@ public FileRecord CreateFile(List<FileNameRecord> fileNameRecords, uint transact
             m_volume.LogClient.WriteLogRecord(m_mftRecord.BaseSegmentReference, m_mftRecord.DataRecord, streamOffset, m_volume.BytesPerFileRecordSegment, NTFSLogOperation.InitializeFileRecordSegment, redoData, NTFSLogOperation.DeallocateFileRecordSegment, new byte[0], transactionID);
             UpdateFileRecordSegment(fileRecordSegment);
 
-            fileRecordSegment.ReferenceCount = (ushort)fileNameRecords.Count; // Each FileNameRecord is about to be indexed
-            fileRecordSegment.IsInUse = true;
-            fileRecordSegment.IsDirectory = isDirectory;
-
             FileRecord fileRecord = new FileRecord(fileRecordSegment);
+            fileRecord.ReferenceCount = (ushort)fileNameRecords.Count; // Each FileNameRecord is about to be indexed
+            fileRecord.IsInUse = true;
+            fileRecord.IsDirectory = isDirectory;
             StandardInformationRecord standardInformation = (StandardInformationRecord)fileRecord.CreateAttributeRecord(AttributeType.StandardInformation, String.Empty);
             standardInformation.CreationTime = fileNameRecords[0].CreationTime;
             standardInformation.ModificationTime = fileNameRecords[0].ModificationTime;
@@ -435,7 +434,7 @@ public void DeleteFile(FileRecord fileRecord, uint transactionID)
         {
             foreach (FileRecordSegment segment in fileRecord.Segments)
             {
-                byte[] undoData = GetFileRecordSegment(segment.SegmentNumber).GetBytes(m_volume.BytesPerFileRecordSegment, m_volume.MinorVersion, false);
+                byte[] undoData = segment.GetBytes(m_volume.BytesPerFileRecordSegment, m_volume.MinorVersion, false);
                 ulong streamOffset = (ulong)(segment.SegmentNumber * m_volume.BytesPerFileRecordSegment);
                 m_volume.LogClient.WriteLogRecord(m_mftRecord.BaseSegmentReference, m_mftRecord.DataRecord, streamOffset, m_volume.BytesPerFileRecordSegment, NTFSLogOperation.DeallocateFileRecordSegment, new byte[0], NTFSLogOperation.InitializeFileRecordSegment, undoData, transactionID);
                 DeallocateFileRecordSegment(segment, transactionID);