NTFS: FileRecordHelper: Minor improvements

TalAloni · TalAloni · commit 6db628a7bf8d · 2018-12-07T11:08:10.000+02:00
diff --git a/DiskAccessLibrary/FileSystems/NTFS/FileRecord/FileRecordHelper.cs b/DiskAccessLibrary/FileSystems/NTFS/FileRecord/FileRecordHelper.cs
@@ -175,7 +175,7 @@ public static void SliceAttributes(List<FileRecordSegment> segments, List<Attrib
                     }
                     else
                     {
-                        NonResidentAttributeRecord nonResidentAttribute = ((NonResidentAttributeRecord)attribute);
+                        NonResidentAttributeRecord nonResidentAttribute = (NonResidentAttributeRecord)attribute;
                         List<NonResidentAttributeRecord> slices = SliceAttributeRecord((NonResidentAttributeRecord)attribute, remainingLengthInCurrentSegment, bytesAvailableInSegment);
                         remainingAttributes.RemoveFirst();
                         slices.Reverse();
@@ -219,21 +219,21 @@ private static NonResidentAttributeRecord FitMaxNumberOfRuns(NonResidentAttribut
                 clusterCount += dataRuns[index].RunLength;
             }
             slice.LowestVCN = clusterCount;
-            slice.DataRunSequence.Add(dataRuns[runIndex]);
             
             if (runIndex == 0)
             {
                 slice.CompressionUnit = record.CompressionUnit;
                 slice.AllocatedLength = record.AllocatedLength;
                 slice.FileSize = record.FileSize;
                 slice.ValidDataLength = record.ValidDataLength;
+                slice.DataRunSequence.Add(dataRuns[runIndex]);
             }
             else
             {
                 // The DataRunSequence of each NonResidentDataRecord fragment starts at absolute LCN
                 long runLength = dataRuns[runIndex].RunLength;
                 long runStartLCN = dataRuns.GetDataClusterLCN(clusterCount);
-                slice.DataRunSequence[0] = new DataRun(runLength, runStartLCN);
+                slice.DataRunSequence.Add(new DataRun(runLength, runStartLCN));
             }
             clusterCount += dataRuns[runIndex].RunLength;
 

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ public static void SliceAttributes(List<FileRecordSegment> segments, List<Attrib`
`175`	`175`	`}`
`176`	`176`	`else`
`177`	`177`	`{`
`178`		`- NonResidentAttributeRecord nonResidentAttribute = ((NonResidentAttributeRecord)attribute);`
	`178`	`+ NonResidentAttributeRecord nonResidentAttribute = (NonResidentAttributeRecord)attribute;`
`179`	`179`	`List<NonResidentAttributeRecord> slices = SliceAttributeRecord((NonResidentAttributeRecord)attribute, remainingLengthInCurrentSegment, bytesAvailableInSegment);`
`180`	`180`	`remainingAttributes.RemoveFirst();`
`181`	`181`	`slices.Reverse();`
`@@ -219,21 +219,21 @@ private static NonResidentAttributeRecord FitMaxNumberOfRuns(NonResidentAttribut`
`219`	`219`	`clusterCount += dataRuns[index].RunLength;`
`220`	`220`	`}`
`221`	`221`	`slice.LowestVCN = clusterCount;`
`222`		`- slice.DataRunSequence.Add(dataRuns[runIndex]);`
`223`	`222`
`224`	`223`	`if (runIndex == 0)`
`225`	`224`	`{`
`226`	`225`	`slice.CompressionUnit = record.CompressionUnit;`
`227`	`226`	`slice.AllocatedLength = record.AllocatedLength;`
`228`	`227`	`slice.FileSize = record.FileSize;`
`229`	`228`	`slice.ValidDataLength = record.ValidDataLength;`
	`229`	`+ slice.DataRunSequence.Add(dataRuns[runIndex]);`
`230`	`230`	`}`
`231`	`231`	`else`
`232`	`232`	`{`
`233`	`233`	`// The DataRunSequence of each NonResidentDataRecord fragment starts at absolute LCN`
`234`	`234`	`long runLength = dataRuns[runIndex].RunLength;`
`235`	`235`	`long runStartLCN = dataRuns.GetDataClusterLCN(clusterCount);`
`236`		`- slice.DataRunSequence[0] = new DataRun(runLength, runStartLCN);`
	`236`	`+ slice.DataRunSequence.Add(new DataRun(runLength, runStartLCN));`
`237`	`237`	`}`
`238`	`238`	`clusterCount += dataRuns[runIndex].RunLength;`
`239`	`239`