NTFS: IndexData: RemoveEntry: Bugfix: IndexOutOfRangeException was thrown in some cases

TalAloni · TalAloni · commit c9f6830b228c · 2018-12-11T21:22:00.000+02:00
diff --git a/DiskAccessLibrary/FileSystems/NTFS/AttributeData/IndexData.cs b/DiskAccessLibrary/FileSystems/NTFS/AttributeData/IndexData.cs
@@ -299,7 +299,14 @@ public void RemoveEntry(byte[] key)
                     if (leaf.IndexEntries.Count == 0)
                     {
                         int indexOfLeafPointer = pathToLeaf[pathToLeaf.Count - 1].Key;
-                        RemovePointer(pathToLeaf.GetRange(0, pathToLeaf.Count - 1), indexOfLeafPointer);
+                        if (pathToLeaf.Count > 1)
+                        {
+                            RemovePointer(pathToLeaf.GetRange(0, pathToLeaf.Count - 1), indexOfLeafPointer);
+                        }
+                        else
+                        {
+                            RemovePointerFromRoot(indexOfLeafPointer);
+                        }
                         DeallocateIndexRecord(leafRecordIndex);
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -299,7 +299,14 @@ public void RemoveEntry(byte[] key)`
`299`	`299`	`if (leaf.IndexEntries.Count == 0)`
`300`	`300`	`{`
`301`	`301`	`int indexOfLeafPointer = pathToLeaf[pathToLeaf.Count - 1].Key;`
`302`		`- RemovePointer(pathToLeaf.GetRange(0, pathToLeaf.Count - 1), indexOfLeafPointer);`
	`302`	`+ if (pathToLeaf.Count > 1)`
	`303`	`+ {`
	`304`	`+ RemovePointer(pathToLeaf.GetRange(0, pathToLeaf.Count - 1), indexOfLeafPointer);`
	`305`	`+ }`
	`306`	`+ else`
	`307`	`+ {`
	`308`	`+ RemovePointerFromRoot(indexOfLeafPointer);`
	`309`	`+ }`
`303`	`310`	`DeallocateIndexRecord(leafRecordIndex);`
`304`	`311`	`}`
`305`	`312`	`}`