KnownHeader, AuthenticationHelper.Digest: Compatibility with .NET Standard 2.0

Author: TalAloni

StandardSocketsHttpHandler/Net/Http/Headers/KnownHeader.cs

@@ -34,8 +34,7 @@ public KnownHeader(string name, HttpHeaderType headerType, HttpHeaderParser pars
             _knownValues = knownValues;
 
             _asciiBytesWithColonSpace = new byte[name.Length + 2]; // + 2 for ':' and ' '
-            int asciiBytes = Encoding.ASCII.GetBytes(name, _asciiBytesWithColonSpace);
-            Debug.Assert(asciiBytes == name.Length);
+            Array.Copy(Encoding.ASCII.GetBytes(name), _asciiBytesWithColonSpace, name.Length);
             _asciiBytesWithColonSpace[_asciiBytesWithColonSpace.Length - 2] = (byte)':';
             _asciiBytesWithColonSpace[_asciiBytesWithColonSpace.Length - 1] = (byte)' ';
         }

StandardSocketsHttpHandler/Net/Http/SocketsHttpHandler/AuthenticationHelper.Digest.cs

@@ -190,8 +190,8 @@ public static bool IsServerNonceStale(DigestResponse digestResponse)
         private static string GetRandomAlphaNumericString()
         {
             const int Length = 16;
-            Span<byte> randomNumbers = stackalloc byte[Length * 2];
-            RandomNumberGenerator.Fill(randomNumbers);
+            byte[] randomNumbers = new byte[Length * 2];
+            RandomNumberGenerator.Create().GetBytes(randomNumbers);
 
             StringBuilder sb = StringBuilderCache.Acquire(Length);
             for (int i = 0; i < randomNumbers.Length;)
@@ -213,17 +213,13 @@ private static string ComputeHash(string data, string algorithm)
 #pragma warning restore CA5351
             {
                 Span<byte> result = stackalloc byte[hash.HashSize / 8]; // HashSize is in bits
-                bool hashComputed = hash.TryComputeHash(Encoding.UTF8.GetBytes(data), result, out int bytesWritten);
-                Debug.Assert(hashComputed && bytesWritten == result.Length);
+                result = hash.ComputeHash(Encoding.UTF8.GetBytes(data));
 
                 StringBuilder sb = StringBuilderCache.Acquire(result.Length * 2);
 
-                Span<char> byteX2 = stackalloc char[2];
                 for (int i = 0; i < result.Length; i++)
                 {
-                    bool formatted = result[i].TryFormat(byteX2, out int charsWritten, "x2");
-                    Debug.Assert(formatted && charsWritten == 2);
-                    sb.Append(byteX2);
+                    sb.Append(result[i].ToString("x2"));
                 }
 
                 return StringBuilderCache.GetStringAndRelease(sb);