Fix Docker build issues and enhance CI

- Rename frontend build stage to 'frontend-builder' to avoid conflicts
- Add VITE_* build args to frontend Dockerfile (needed at build time)
- Move VITE_* from runtime env to build args in docker-compose
- Update docker-build.yml to test docker-compose build first
- Fix backend build context/file paths in CI workflow
- Only push images after compose build succeeds

Author: TamTunnel

.github/workflows/docker-build.yml

@@ -3,16 +3,39 @@ name: Docker Build
 on:
   push:
     branches: [main]
+  pull_request:
+    branches: [main]
   workflow_dispatch:
 
 env:
   REGISTRY: ghcr.io
   IMAGE_PREFIX: ${{ github.repository }}
 
 jobs:
+  # Test docker-compose build (same as Coolify would do)
+  compose-build:
+    name: Docker Compose Build Test
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3
+      
+      - name: Build with docker-compose
+        run: docker compose build --no-cache
+      
+      - name: Verify all images built
+        run: |
+          docker images | grep constellation
+          echo "✅ All images built successfully"
+
+  # Build and push individual backend images
   build-backend:
     name: Build Backend Images
     runs-on: ubuntu-latest
+    needs: compose-build  # Only push if compose build succeeds
+    if: github.event_name == 'push' && github.ref == 'refs/heads/main'
     permissions:
       contents: read
       packages: write
@@ -46,16 +69,20 @@ jobs:
       - name: Build and push
         uses: docker/build-push-action@v5
         with:
-          context: ./backend/${{ matrix.service }}
+          context: ./backend
+          file: ./backend/${{ matrix.service }}/Dockerfile
           push: true
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
           cache-from: type=gha
           cache-to: type=gha,mode=max
 
+  # Build and push frontend image
   build-frontend:
     name: Build Frontend Image
     runs-on: ubuntu-latest
+    needs: compose-build  # Only push if compose build succeeds
+    if: github.event_name == 'push' && github.ref == 'refs/heads/main'
     permissions:
       contents: read
       packages: write

docker-compose.yml

@@ -113,14 +113,14 @@ services:
     build:
       context: ./frontend/web
       dockerfile: Dockerfile
+      args:
+        VITE_CORE_ORBITS_URL: ${VITE_CORE_ORBITS_URL:-http://localhost:8001}
+        VITE_ROUTING_URL: ${VITE_ROUTING_URL:-http://localhost:8002}
+        VITE_GROUND_SCHEDULER_URL: ${VITE_GROUND_SCHEDULER_URL:-http://localhost:8003}
+        VITE_AI_AGENTS_URL: ${VITE_AI_AGENTS_URL:-http://localhost:8004}
     container_name: constellation-frontend
     ports:
       - "3000:80"
-    environment:
-      VITE_CORE_ORBITS_URL: ${VITE_CORE_ORBITS_URL:-http://localhost:8001}
-      VITE_ROUTING_URL: ${VITE_ROUTING_URL:-http://localhost:8002}
-      VITE_GROUND_SCHEDULER_URL: ${VITE_GROUND_SCHEDULER_URL:-http://localhost:8003}
-      VITE_AI_AGENTS_URL: ${VITE_AI_AGENTS_URL:-http://localhost:8004}
     depends_on:
       - core-orbits
       - routing

frontend/web/Dockerfile

@@ -1,15 +1,31 @@
-FROM node:20-alpine as build
+# Build stage
+FROM node:20-alpine AS frontend-builder
 
 WORKDIR /app
 
+# Accept build args for API URLs (needed at build time for Vite)
+ARG VITE_CORE_ORBITS_URL
+ARG VITE_ROUTING_URL
+ARG VITE_GROUND_SCHEDULER_URL
+ARG VITE_AI_AGENTS_URL
+
+# Set them as environment variables for the build
+ENV VITE_CORE_ORBITS_URL=${VITE_CORE_ORBITS_URL}
+ENV VITE_ROUTING_URL=${VITE_ROUTING_URL}
+ENV VITE_GROUND_SCHEDULER_URL=${VITE_GROUND_SCHEDULER_URL}
+ENV VITE_AI_AGENTS_URL=${VITE_AI_AGENTS_URL}
+
 COPY package*.json ./
 RUN npm ci
 
 COPY . .
 RUN npm run build
 
+# Production stage
 FROM nginx:alpine
-COPY --from=build /app/dist /usr/share/nginx/html
+
+COPY --from=frontend-builder /app/dist /usr/share/nginx/html
 COPY nginx.conf /etc/nginx/conf.d/default.conf
+
 EXPOSE 80
 CMD ["nginx", "-g", "daemon off;"]