Minor changes for Start template (#29)

- Add fix to use typeof router to correctly reference the type of the
router instance
- Corrected usage for scrollRestoration placement
- Fix forbidden non-null assertion

Author: kyziq

templates/react/add-on/start/assets/src/client.tsx

@@ -3,8 +3,6 @@ import { StartClient } from '@tanstack/start'
 
 import { createRouter } from './router'
 
-const router = createRouter({
-  scrollRestoration: true,
-})
+const router = createRouter()
 
-hydrateRoot(document!, <StartClient router={router} />)
+hydrateRoot(document, <StartClient router={router} />)

templates/react/add-on/start/assets/src/router.tsx.ejs

@@ -11,7 +11,10 @@ import './styles.css'
 
 // Create a new router instance
 export const createRouter = () => {
-  const router = createTanstackRouter({ routeTree })
+  const router = createTanstackRouter({
+    routeTree,
+    scrollRestoration: true,
+  })
   return router
 }
 
@@ -46,6 +49,6 @@ const router = createRouter()
 // Register the router instance for type safety
 declare module '@tanstack/react-router' {
   interface Register {
-    router: router
+    router: typeof router
   }
 }