fix: install with npm when using other pm (#47)

Co-authored-by: FatahChan <[email protected]>

Author: jherr

src/create-app.ts

@@ -352,7 +352,7 @@ export async function createApp(
     copyFiles(templateDirBase, ['./toolchain/biome.json'], true)
   }
 
-  // Setup the main, reportWebVitals and index.html files
+  // Setup reportWebVitals
   if (!isAddOnEnabled('start') && options.framework === 'react') {
     if (options.typescript) {
       await templateFile(templateDirBase, './src/reportWebVitals.ts.ejs')

src/options.ts

@@ -52,7 +52,7 @@ export async function normalizeOptions(
       projectName: cliOptions.projectName,
       typescript,
       tailwind,
-      packageManager: cliOptions.packageManager || DEFAULT_PACKAGE_MANAGER,
+      packageManager: cliOptions.packageManager || getPackageManager() || DEFAULT_PACKAGE_MANAGER,
       toolchain: cliOptions.toolchain || DEFAULT_TOOLCHAIN,
       mode: cliOptions.template === 'file-router' ? FILE_ROUTER : CODE_ROUTER,
       git: !!cliOptions.git,

src/package-manager.ts

@@ -19,5 +19,5 @@ export function getPackageManager(): PackageManager | undefined {
     userAgent.startsWith(manager),
   )
 
-  return packageManager || DEFAULT_PACKAGE_MANAGER
+  return packageManager
 }

tests/snapshots/cra/cr-js-npm.json

@@ -1,5 +1,5 @@
 import { readFile } from 'node:fs/promises'
-import { dirname, resolve, basename, extname } from 'node:path'
+import { dirname, join, basename, extname } from 'node:path'
 
 import { createDefaultEnvironment } from '../src/environment.js'
 
@@ -13,7 +13,6 @@ export function createTestEnvironment(projectName: string) {
     commands: Array<{
       command: string
       args: Array<string>
-      cwd: string
     }>
   } = {
     files: {},
@@ -22,7 +21,7 @@ export function createTestEnvironment(projectName: string) {
 
   const isTemplatePath = (path: string) => dirname(path).includes('templates')
   const trimProjectRelativePath = (path: string) =>
-    resolve(
+    join(
       dirname(path).replace(new RegExp(`^.*/${projectName}`), ''),
       basename(path),
     )
@@ -38,15 +37,10 @@ export function createTestEnvironment(projectName: string) {
       output.files[relPath] = contents
     }
   }
-  environment.execute = async (
-    command: string,
-    args: Array<string>,
-    cwd: string,
-  ) => {
+  environment.execute = async (command: string, args: Array<string>) => {
     output.commands.push({
       command,
       args,
-      cwd,
     })
   }
   environment.readFile = async (path: string, encoding?: BufferEncoding) => {