checkpoint

Author: samwillis

packages/db/tests/query/group-by.test.ts

@@ -1100,7 +1100,6 @@ function createGroupByTests(autoIndex: `off` | `eager`): void {
                 state: orders.customer?.address?.state,
                 order_count: count(orders.id),
                 total_amount: sum(orders.amount),
-                cities: orders.customer?.address?.city,
               })),
         })
 
@@ -1250,7 +1249,6 @@ function createGroupByTests(autoIndex: `off` | `eager`): void {
                   ),
                 order_count: count(orders.id),
                 total_amount: sum(orders.amount),
-                has_tracking: isNotUndefined(orders.shipping?.tracking),
               })),
         })
 

packages/db/tests/query/order-by.test.ts

@@ -2,7 +2,7 @@ import { beforeEach, describe, expect, it } from "vitest"
 import { createCollection } from "../../src/collection.js"
 import { mockSyncCollectionOptions } from "../utls.js"
 import { createLiveQueryCollection } from "../../src/query/live-query-collection.js"
-import { eq, gt } from "../../src/query/builder/functions.js"
+import { eq, gt, isNotUndefined } from "../../src/query/builder/functions.js"
 
 type Person = {
   id: string
@@ -1183,7 +1183,7 @@ function createOrderByTests(autoIndex: `off` | `eager`): void {
         const collection = createLiveQueryCollection((q) =>
           q
             .from({ persons: personsCollection })
-            .where(({ persons }) => persons.address !== undefined)
+            .where(({ persons }) => isNotUndefined(persons.address))
             .orderBy(({ persons }) => persons.address?.coordinates?.lat, `asc`)
             .select(({ persons }) => ({
               id: persons.id,
@@ -1233,9 +1233,9 @@ function createOrderByTests(autoIndex: `off` | `eager`): void {
         const results = Array.from(collection.values())
         expect(results).toHaveLength(4)
 
-        // Person without profile should have score 0 and be last
-        expect(results.map((r) => r.score)).toEqual([92, 85, 78, 0])
-        expect(results[3]!.name).toBe(`Test Person`)
+        // Person without profile should have undefined score and be first (undefined sorts first)
+        expect(results.map((r) => r.score)).toEqual([undefined, 92, 85, 78])
+        expect(results[0]!.name).toBe(`Test Person`)
       })
 
       it(`maintains ordering during live updates of nested properties`, async () => {
@@ -1302,17 +1302,17 @@ function createOrderByTests(autoIndex: `off` | `eager`): void {
         const results = Array.from(collection.values())
         expect(results).toHaveLength(3)
 
-        // Should be ordered: Los Angeles, New York, undefined (John Smith has no address)
-        // Note: undefined values in ORDER BY may be handled differently by the query engine
+        // Should be ordered: undefined, Los Angeles, New York (undefined sorts first)
+        // Note: undefined values in ORDER BY sort first in our implementation
         expect(results.map((r) => r.city)).toEqual([
+          undefined,
           `Los Angeles`,
           `New York`,
-          undefined,
         ])
         expect(results.map((r) => r.name)).toEqual([
+          `John Smith`,
           `Jane Doe`,
           `John Doe`,
-          `John Smith`,
         ])
       })
     })

packages/db/tests/query/where.test.ts

@@ -11,6 +11,8 @@ import {
   gt,
   gte,
   inArray,
+  isNotNull,
+  isNotUndefined,
   length,
   like,
   lower,
@@ -1436,7 +1438,7 @@ function createWhereTests(autoIndex: `off` | `eager`): void {
               .select(({ emp }) => ({
                 id: emp.id,
                 name: emp.name,
-                hasAddress: emp.contact?.address !== null,
+                hasAddress: isNotNull(emp.contact?.address),
               })),
         })
 
@@ -1451,7 +1453,7 @@ function createWhereTests(autoIndex: `off` | `eager`): void {
           query: (q) =>
             q
               .from({ emp: employeesCollection })
-              .where(({ emp }) => emp.profile !== undefined)
+              .where(({ emp }) => isNotUndefined(emp.profile))
               .select(({ emp }) => ({
                 id: emp.id,
                 name: emp.name,
@@ -1524,7 +1526,7 @@ function createWhereTests(autoIndex: `off` | `eager`): void {
           query: (q) =>
             q
               .from({ emp: employeesCollection })
-              .where(({ emp }) => emp.contact?.emergency !== undefined)
+              .where(({ emp }) => isNotUndefined(emp.contact?.emergency))
               .select(({ emp }) => ({
                 id: emp.id,
                 name: emp.name,
@@ -1613,7 +1615,7 @@ function createWhereTests(autoIndex: `off` | `eager`): void {
           query: (q) =>
             q
               .from({ emp: employeesCollection })
-              .where(({ emp }) => emp.profile?.skills !== undefined)
+              .where(({ emp }) => isNotUndefined(emp.profile?.skills))
               .select(({ emp }) => ({
                 id: emp.id,
                 name: emp.name,