tests and lint pass!!

Author: samwillis

packages/db/tests/query/builder/buildQuery.test.ts

@@ -63,7 +63,7 @@ describe(`buildQuery function`, () => {
         .join(
           { departments: departmentsCollection },
           ({ employees, departments }) =>
-            eq(employees.department_id, departments?.id)
+            eq(employees.department_id, departments.id)
         )
         .select(({ employees, departments }) => ({
           employee_name: employees.name,
@@ -122,7 +122,7 @@ describe(`buildQuery function`, () => {
       q
         .from({ comment: commentsCollection })
         .join({ user: usersCollection }, ({ comment, user }) =>
-          eq(comment.user_id, user?.id)
+          eq(comment.user_id, user.id)
         )
         .where(({ comment }) => or(eq(comment.id, 1), eq(comment.id, 2)))
         .orderBy(({ comment }) => comment.date, `desc`)

packages/db/tests/query/builder/callback-types.test-d.ts

@@ -482,8 +482,8 @@ describe(`Query Builder Callback Types`, () => {
         .from({ user: usersCollection })
         .join({ dept: departmentsCollection }, ({ user, dept }) => {
           expectTypeOf(user.id).toEqualTypeOf<Ref<number>>()
-          expectTypeOf(dept?.id).toEqualTypeOf<Ref<number>>()
-          expectTypeOf(dept?.location).toEqualTypeOf<Ref<string>>()
+          expectTypeOf(dept.id).toEqualTypeOf<Ref<number>>()
+          expectTypeOf(dept.location).toEqualTypeOf<Ref<string>>()
           return eq(user.department_id, dept.id)
         })
         .join({ project: projectsCollection }, ({ user, dept, project }) => {

packages/db/tests/query/builder/join.test.ts

@@ -75,7 +75,7 @@ describe(`QueryBuilder.join`, () => {
           eq(employees.department_id, departments.id)
       )
       .join({ projects: projectsCollection }, ({ departments, projects }) =>
-        eq(departments?.id, projects?.department_id)
+        eq(departments?.id, projects.department_id)
       )
 
     const builtQuery = getQueryIR(query)

packages/db/tests/query/builder/select.test.ts

@@ -301,7 +301,7 @@ describe(`QueryBuilder.select`, () => {
         hasProfile: not(isUndefined(employees.profile)),
         profileBio: employees.profile?.bio,
         addressStreet: employees.address?.street,
-        contactEmail: employees.profile?.contact?.email,
+        contactEmail: employees.profile?.contact.email,
       }))
 
     const builtQuery = getQueryIR(query)

packages/db/tests/query/group-by.test.ts

@@ -1094,9 +1094,9 @@ function createGroupByTests(autoIndex: `off` | `eager`): void {
             q
               .from({ orders: ordersCollection })
               .where(({ orders }) => isNotUndefined(orders.customer?.address))
-              .groupBy(({ orders }) => orders.customer?.address?.state)
+              .groupBy(({ orders }) => orders.customer?.address.state)
               .select(({ orders }) => ({
-                state: orders.customer?.address?.state,
+                state: orders.customer?.address.state,
                 order_count: count(orders.id),
                 total_amount: sum(orders.amount),
               })),
@@ -1199,9 +1199,9 @@ function createGroupByTests(autoIndex: `off` | `eager`): void {
               .where(({ orders }) =>
                 isNotUndefined(orders.customer?.preferences)
               )
-              .groupBy(({ orders }) => orders.customer?.preferences?.newsletter)
+              .groupBy(({ orders }) => orders.customer?.preferences.newsletter)
               .select(({ orders }) => ({
-                newsletter_subscribed: orders.customer?.preferences?.newsletter,
+                newsletter_subscribed: orders.customer?.preferences.newsletter,
                 order_count: count(orders.id),
                 total_amount: sum(orders.amount),
                 avg_amount: avg(orders.amount),

packages/db/tests/query/join.test.ts

@@ -486,8 +486,8 @@ function createJoinTests(autoIndex: `off` | `eager`): void {
                 `inner`
               )
               .select(({ user, dept }) => ({
-                user_name: user?.name,
-                department_name: dept?.name,
+                user_name: user.name,
+                department_name: dept.name,
               })),
         })
 
@@ -561,8 +561,8 @@ function createJoinTests(autoIndex: `off` | `eager`): void {
                 `inner`
               )
               .select(({ user, dept }) => ({
-                user_name: user?.name,
-                department_name: dept?.name,
+                user_name: user.name,
+                department_name: dept.name,
               })),
         })
 
@@ -601,8 +601,8 @@ function createJoinTests(autoIndex: `off` | `eager`): void {
               )
               .select(({ user, dept }) => ({
                 user_id: user.id,
-                user_name: user?.name,
-                department_id: user?.department_id,
+                user_name: user.name,
+                department_id: user.department_id,
                 department_name: dept?.name,
               })),
         })

packages/db/tests/query/order-by.test.ts

@@ -1129,12 +1129,12 @@ function createOrderByTests(autoIndex: `off` | `eager`): void {
         const collection = createLiveQueryCollection((q) =>
           q
             .from({ persons: personsCollection })
-            .orderBy(({ persons }) => persons.profile?.stats?.rating, `desc`)
+            .orderBy(({ persons }) => persons.profile?.stats.rating, `desc`)
             .select(({ persons }) => ({
               id: persons.id,
               name: persons.name,
-              rating: persons.profile?.stats?.rating,
-              tasksCompleted: persons.profile?.stats?.tasksCompleted,
+              rating: persons.profile?.stats.rating,
+              tasksCompleted: persons.profile?.stats.tasksCompleted,
             }))
         )
         await collection.preload()
@@ -1184,12 +1184,12 @@ function createOrderByTests(autoIndex: `off` | `eager`): void {
           q
             .from({ persons: personsCollection })
             .where(({ persons }) => isNotUndefined(persons.address))
-            .orderBy(({ persons }) => persons.address?.coordinates?.lat, `asc`)
+            .orderBy(({ persons }) => persons.address?.coordinates.lat, `asc`)
             .select(({ persons }) => ({
               id: persons.id,
               name: persons.name,
               city: persons.address?.city,
-              lat: persons.address?.coordinates?.lat,
+              lat: persons.address?.coordinates.lat,
             }))
         )
         await collection.preload()