Skip to content

Commit 8e4b380

Browse files
fix(form-core): Remove early canSubmit check in _handleSubmit (#1990)
- Remove stale canSubmit check that prevented onSubmitInvalid from being called - On first render, canSubmit was true even with invalid default values - Proper validation checks after this point correctly handle onSubmitInvalid - Fixes: onSubmitInvalid not called when form is invalid with default values
1 parent 16dca26 commit 8e4b380

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

packages/form-core/src/FormApi.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2066,15 +2066,6 @@ export class FormApi<
20662066
const submitMetaArg =
20672067
submitMeta ?? (this.options.onSubmitMeta as TSubmitMeta)
20682068

2069-
if (!this.state.canSubmit && !this._devtoolsSubmissionOverride) {
2070-
this.options.onSubmitInvalid?.({
2071-
value: this.state.values,
2072-
formApi: this,
2073-
meta: submitMetaArg,
2074-
})
2075-
return
2076-
}
2077-
20782069
this.baseStore.setState((d) => ({ ...d, isSubmitting: true }))
20792070

20802071
const done = () => {

0 commit comments

Comments
 (0)