fix(form-core): canSubmitWhenInvalid not allowing form submission

Author: 814k31

packages/form-core/src/FormApi.ts

@@ -1780,7 +1780,7 @@ export class FormApi<
 
     await this.validateAllFields('submit')
 
-    if (!this.state.isFieldsValid) {
+    if (!this.options.canSubmitWhenInvalid && !this.state.isFieldsValid) {
       done()
       this.options.onSubmitInvalid?.({
         value: this.state.values,
@@ -1792,7 +1792,7 @@ export class FormApi<
     await this.validate('submit')
 
     // Fields are invalid, do not submit
-    if (!this.state.isValid) {
+    if (!this.options.canSubmitWhenInvalid && !this.state.isValid) {
       done()
       this.options.onSubmitInvalid?.({
         value: this.state.values,

packages/form-core/tests/FormApi.spec.ts

@@ -3255,6 +3255,31 @@ describe('form api', () => {
     expect(form.state.canSubmit).toBe(true)
   })
 
+  it('should submit, when the form is invalid, with canSubmitWhenInvalid', async () => {
+    const onSubmitFake = vi.fn();
+    const form = new FormApi({
+      defaultValues: {
+        firstName: '',
+      },
+      canSubmitWhenInvalid: true,
+      validators: {
+        onMount: () => {
+          return {
+            form: 'something went wrong',
+            fields: {
+              firstName: 'first name is required',
+            },
+          }
+        },
+      },
+      onSubmit: onSubmitFake
+    })
+    form.mount()
+    expect(form.state.isValid).toBe(false)
+    await form.handleSubmit()
+    expect(onSubmitFake).toHaveBeenCalled();
+  })
+
   it('should pass the current values to the Standard Schema when calling parseValuesWithSchema', async () => {
     const schema = z.object({
       firstName: z.string().min(3),