Skip to content

Commit 0502371

Browse files
authored
perf(vue-query): avoid unnecessary deep watch (#5764)
1 parent fe7df40 commit 0502371

File tree

5 files changed

+17
-37
lines changed

5 files changed

+17
-37
lines changed

packages/vue-query/src/useBaseQuery.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -88,14 +88,10 @@ export function useBaseQuery<
8888
{ immediate: true },
8989
)
9090

91-
watch(
92-
defaultedOptions,
93-
() => {
94-
observer.setOptions(defaultedOptions.value)
95-
updateState(state, observer.getCurrentResult())
96-
},
97-
{ deep: true },
98-
)
91+
watch(defaultedOptions, () => {
92+
observer.setOptions(defaultedOptions.value)
93+
updateState(state, observer.getCurrentResult())
94+
})
9995

10096
onScopeDispose(() => {
10197
unsubscribe()

packages/vue-query/src/useIsFetching.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,9 @@ export function useIsFetching(
2727
isFetching.value = queryClient.isFetching(filters)
2828
})
2929

30-
watch(
31-
filters,
32-
() => {
33-
isFetching.value = queryClient.isFetching(filters)
34-
},
35-
{ deep: true },
36-
)
30+
watch(filters, () => {
31+
isFetching.value = queryClient.isFetching(filters)
32+
})
3733

3834
onScopeDispose(() => {
3935
unsubscribe()

packages/vue-query/src/useIsMutating.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,9 @@ export function useIsMutating(
2727
isMutating.value = queryClient.isMutating(filters)
2828
})
2929

30-
watch(
31-
filters,
32-
() => {
33-
isMutating.value = queryClient.isMutating(filters)
34-
},
35-
{ deep: true },
36-
)
30+
watch(filters, () => {
31+
isMutating.value = queryClient.isMutating(filters)
32+
})
3733

3834
onScopeDispose(() => {
3935
unsubscribe()

packages/vue-query/src/useMutation.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -167,13 +167,9 @@ export function useMutation<
167167
})
168168
}
169169

170-
watch(
171-
options,
172-
() => {
173-
observer.setOptions(queryClient.defaultMutationOptions(options.value))
174-
},
175-
{ deep: true },
176-
)
170+
watch(options, () => {
171+
observer.setOptions(queryClient.defaultMutationOptions(options.value))
172+
})
177173

178174
onScopeDispose(() => {
179175
unsubscribe()

packages/vue-query/src/useQueries.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -191,14 +191,10 @@ export function useQueries<T extends any[]>({
191191
{ immediate: true },
192192
)
193193

194-
watch(
195-
unreffedQueries,
196-
() => {
197-
observer.setQueries(defaultedQueries.value)
198-
state.splice(0, state.length, ...observer.getCurrentResult())
199-
},
200-
{ deep: true },
201-
)
194+
watch(defaultedQueries, () => {
195+
observer.setQueries(defaultedQueries.value)
196+
state.splice(0, state.length, ...observer.getCurrentResult())
197+
})
202198

203199
onScopeDispose(() => {
204200
unsubscribe()

0 commit comments

Comments
 (0)