Skip to content

Commit 10db6b3

Browse files
committed
refactor: remove observer factory
1 parent 6400708 commit 10db6b3

File tree

3 files changed

+5
-12
lines changed

3 files changed

+5
-12
lines changed

src/react/useBaseQuery.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,10 @@ import { QueryObserver } from '../core/queryObserver'
55
import { useQueryErrorResetBoundary } from './QueryErrorResetBoundary'
66
import { useQueryClient } from './QueryClientProvider'
77
import { UseBaseQueryOptions } from './types'
8-
import { QueryClient, QueryObserverOptions } from '../core'
98

109
export function useBaseQuery<TData, TError, TQueryFnData, TQueryData>(
1110
options: UseBaseQueryOptions<TData, TError, TQueryFnData, TQueryData>,
12-
createObserver: (
13-
queryClient: QueryClient,
14-
options: QueryObserverOptions<any, any, any, any>
15-
) => QueryObserver<any, any, any, any>
11+
Observer: typeof QueryObserver
1612
) {
1713
const queryClient = useQueryClient()
1814
const isMounted = useIsMounted()
@@ -27,7 +23,7 @@ export function useBaseQuery<TData, TError, TQueryFnData, TQueryData>(
2723
// Create query observer
2824
const observerRef = React.useRef<QueryObserver<any, any, any, any>>()
2925
const observer =
30-
observerRef.current || createObserver(queryClient, defaultedOptions)
26+
observerRef.current || new Observer(queryClient, defaultedOptions)
3127
observerRef.current = observer
3228

3329
// Update options

src/react/useInfiniteQuery.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { QueryObserver } from '../core'
12
import { InfiniteQueryObserver } from '../core/infiniteQueryObserver'
23
import { QueryFunction, QueryKey } from '../core/types'
34
import { parseQueryArgs } from '../core/utils'
@@ -40,7 +41,6 @@ export function useInfiniteQuery<TData, TError, TQueryFnData = TData>(
4041
const options = parseQueryArgs(arg1, arg2, arg3)
4142
return useBaseQuery(
4243
options,
43-
(client, defaultedOptions) =>
44-
new InfiniteQueryObserver(client, defaultedOptions)
44+
InfiniteQueryObserver as typeof QueryObserver
4545
) as UseInfiniteQueryResult<TData, TError>
4646
}

src/react/useQuery.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,5 @@ export function useQuery<TData, TError, TQueryFnData = TData>(
3838
arg3?: UseQueryOptions<TData, TError, TQueryFnData>
3939
): UseQueryResult<TData, TError> {
4040
const parsedOptions = parseQueryArgs(arg1, arg2, arg3)
41-
return useBaseQuery(
42-
parsedOptions,
43-
(client, defaultedOptions) => new QueryObserver(client, defaultedOptions)
44-
)
41+
return useBaseQuery(parsedOptions, QueryObserver)
4542
}

0 commit comments

Comments
 (0)