Skip to content

Commit 627062b

Browse files
authored
test(react-query): resolve ESLint typescript-eslint/require-await warnings (#8886)
1 parent 5acf8e6 commit 627062b

File tree

1 file changed

+20
-12
lines changed

1 file changed

+20
-12
lines changed

packages/react-query/src/__tests__/useMutation.test.tsx

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -271,24 +271,28 @@ describe('useMutation', () => {
271271

272272
function Page() {
273273
const { mutateAsync } = useMutation({
274-
mutationFn: async (text: string) => text,
275-
onSuccess: async () => {
274+
mutationFn: (text: string) => Promise.resolve(text),
275+
onSuccess: () => {
276276
callbacks.push('useMutation.onSuccess')
277+
return Promise.resolve()
277278
},
278-
onSettled: async () => {
279+
onSettled: () => {
279280
callbacks.push('useMutation.onSettled')
281+
return Promise.resolve()
280282
},
281283
})
282284

283285
React.useEffect(() => {
284286
setActTimeout(async () => {
285287
try {
286288
const result = await mutateAsync('todo', {
287-
onSuccess: async () => {
289+
onSuccess: () => {
288290
callbacks.push('mutateAsync.onSuccess')
291+
return Promise.resolve()
289292
},
290-
onSettled: async () => {
293+
onSettled: () => {
291294
callbacks.push('mutateAsync.onSettled')
295+
return Promise.resolve()
292296
},
293297
})
294298
callbacks.push(`mutateAsync.result:${result}`)
@@ -318,23 +322,27 @@ describe('useMutation', () => {
318322
function Page() {
319323
const { mutateAsync } = useMutation({
320324
mutationFn: async (_text: string) => Promise.reject(new Error('oops')),
321-
onError: async () => {
325+
onError: () => {
322326
callbacks.push('useMutation.onError')
327+
return Promise.resolve()
323328
},
324-
onSettled: async () => {
329+
onSettled: () => {
325330
callbacks.push('useMutation.onSettled')
331+
return Promise.resolve()
326332
},
327333
})
328334

329335
React.useEffect(() => {
330336
setActTimeout(async () => {
331337
try {
332338
await mutateAsync('todo', {
333-
onError: async () => {
339+
onError: () => {
334340
callbacks.push('mutateAsync.onError')
341+
return Promise.resolve()
335342
},
336-
onSettled: async () => {
343+
onSettled: () => {
337344
callbacks.push('mutateAsync.onSettled')
345+
return Promise.resolve()
338346
},
339347
})
340348
} catch (error) {
@@ -787,12 +795,12 @@ describe('useMutation', () => {
787795

788796
function Page() {
789797
const { mutate: succeed, isSuccess } = useMutation({
790-
mutationFn: async () => '',
798+
mutationFn: () => Promise.resolve(''),
791799
meta: { metaSuccessMessage },
792800
})
793801
const { mutate: error, isError } = useMutation({
794-
mutationFn: async () => {
795-
throw new Error('')
802+
mutationFn: () => {
803+
return Promise.reject(new Error(''))
796804
},
797805
meta: { metaErrorMessage },
798806
})

0 commit comments

Comments
 (0)