When is focus and online related global window listeners removed/cleaned up ?

[omar-oslo]

We are using react-query 2.26.4 and found that the following event listeners are not cleaned up.

window.addEventListener('visibilitychange', handleFocus, false)
window.addEventListener('focus', handleFocus, false)
window.addEventListener('online', handleOnline, false)

Is there any documentation on when/how to cleanup these event listeners ? When I added breakpoint in the code that removes the listener, that was never hit by debugger. Thanks.

window.removeEventListener(.., ..)

[TkDodo]

I fixed this with v4.

[omar-oslo]

What about v 3.x ? Is it fixed there as well ?

[TkDodo]

No

[omar-oslo]

Thanks. Can you pls point to the commit which fixes these eventlistener cleanup in v4 ?

[TkDodo]

seems like I've actually fixed this for v3 as well:

• fix: unsubscribe leak #3092

[omar-oslo]

Thanks. Found the 3.x fix version(3.34.3) in this comment. #3092 (comment)