Replies: 2 comments
-
I've been bit by this, I would've thought setting I only want Suspense to be triggered in certain scenarios, and the fact that it doesn't let me do this is a huge deal-breaker. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Made a PR to fix this #6415 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
First of all, thanks for all the great work on the TanStack ecosystem 🙏
I recently started to build a solid-js project with solid-query but one thing is quite baffling to me. The Important Differences between Solid Query & React Query documentation says:
As a default behaviour, that is fine (albeit a bit unexpected) but you cannot even say
suspense: false
to disable suspense for a particularcreateQuery
call (configuring the globalQueryClient
also doesn't do anything). To me this behaviour is not only unexpected but seems like an oversight and a missing feature. I think it's quite common that you may want to use suspense for certain queries but not for all. With the current behaviour, it seems to be impossible to have both types of queries. Moreso, the wholeoptions.suspense
flag doesn't do anything even though you can still give it and the types also have it.Wondering if this a conscious design choice or an oversight and should something be done about it? Personally I'd expect the default behaviour to not use suspense which you can overwrite either globally (for
QueryClient
) or locally (forcreateQuery
).Beta Was this translation helpful? Give feedback.
All reactions