fix optimizeDeps

Author: schiller-manuel

packages/react-start/src/plugin/vite.ts

@@ -1,5 +1,8 @@
 import { fileURLToPath } from 'node:url'
-import { TanStackStartVitePluginCore } from '@tanstack/start-plugin-core'
+import {
+  TanStackStartVitePluginCore,
+  VITE_ENVIRONMENT_NAMES,
+} from '@tanstack/start-plugin-core'
 import path from 'pathe'
 import type { TanStackStartInputConfig } from '@tanstack/start-plugin-core'
 import type { PluginOption } from 'vite'
@@ -43,14 +46,15 @@ export function tanstackStart(
   return [
     {
       name: 'tanstack-react-start:config',
-      configEnvironment() {
+      configEnvironment(env, userConfig) {
         return {
           resolve: {
             dedupe: ['react', 'react-dom', '@tanstack/react-router'],
 
-            external: isInsideRouterMonoRepo
-              ? ['@tanstack/react-router', '@tanstack/react-router-devtools']
-              : undefined,
+            external:
+              userConfig.resolve?.noExternal === true || !isInsideRouterMonoRepo
+                ? undefined
+                : ['@tanstack/react-router', '@tanstack/react-router-devtools'],
           },
 
           optimizeDeps: {
@@ -62,6 +66,9 @@ export function tanstackStart(
               'react-dom',
               'react-dom/client',
               '@tanstack/react-router',
+              ...(env === VITE_ENVIRONMENT_NAMES.server
+                ? ['react-dom/server']
+                : []),
             ],
           },
         }

packages/start-plugin-core/src/index.ts

@@ -2,3 +2,5 @@ export type { TanStackStartInputConfig } from './schema'
 
 export { TanStackStartVitePluginCore } from './plugin'
 export { resolveViteId } from './utils'
+
+export { VITE_ENVIRONMENT_NAMES } from './constants'

packages/start-plugin-core/src/plugin.ts

@@ -218,6 +218,18 @@ export function TanStackStartVitePluginCore(
                   viteConfig.environments?.[VITE_ENVIRONMENT_NAMES.server]
                     ?.build?.copyPublicDir ?? false,
               },
+              optimizeDeps: {
+                exclude: [
+                  ...Object.values(VIRTUAL_MODULES),
+                  ...result.optimizeDeps.exclude.sort(),
+                  ...additionalOptimizeDeps.exclude,
+                  `@tanstack/${corePluginOpts.framework}-start/server-functions-server`,
+                ],
+                include: [
+                  ...additionalOptimizeDeps.include,
+                  ...result.optimizeDeps.include.sort(),
+                ],
+              },
             },
           },
           resolve: {