fix(solid-router): emit onBeforeRouteMount with createComputed (#5745)

birkskyum · web-flow · commit ce2a6a8a311e · 2025-11-03T20:46:59.000+01:00
diff --git a/packages/solid-router/src/Transitioner.tsx b/packages/solid-router/src/Transitioner.tsx
@@ -102,7 +102,7 @@ export function Transitioner() {
     ),
   )
 
-  Solid.createRenderEffect(
+  Solid.createComputed(
     Solid.on(
       [isPagePending, previousIsPagePending],
       ([isPagePending, previousIsPagePending]) => {

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ export function Transitioner() {`
`102`	`102`	`),`
`103`	`103`	`)`
`104`	`104`
`105`		`- Solid.createRenderEffect(`
	`105`	`+ Solid.createComputed(`
`106`	`106`	`Solid.on(`
`107`	`107`	`[isPagePending, previousIsPagePending],`
`108`	`108`	`([isPagePending, previousIsPagePending]) => {`