Type error with href + reloadDocument in custom link

[hornta]

I've made a custom link component and I expect to be able to write links to external resources like this. But the library gives an error. I don't think it should be a type error if both href and reloadDocument is passed. WDYT?
<Anchor href="https://www.google.com/chrome/" reloadDocument>Google Chrome</Anchor>

Property 'to' is missing in type '{ children: string; href: string; reloadDocument: true; }' but required in type 'RequiredToOptions<Router<RootRoute<undefined, MyRouterContext, AnyContext, (ctx: BeforeLoadContextO...

Custom link

const BasicLinkComponent = ({ className, ...props }: ComponentProps<"a">) => {
	return (
		<a
			className={clsx("hover:underline text-amber-700 font-medium", className)}
			{...props}
		/>
	);
};

const CreatedLinkComponent = createLink(BasicLinkComponent);

export const Anchor: LinkComponent<typeof BasicLinkComponent> = (props) => {
	return <CreatedLinkComponent preload={"intent"} {...props} />;
};

[schiller-manuel]

<Link> or any custom link component based on it is just not meant for external links. Only for internal links. Just use a regular <a>.

[schiller-manuel]

to accepts a string, doesnt it?

this worked: https://stackblitz.com/edit/tanstack-router-dya9vjy5?file=src%2Froutes%2F__root.tsx&preset=node

[micah-redwood]

Weird, I'm seeing type errors for both of these to values in the link you shared. Am I missing something?

[schiller-manuel]

right must have been stackblitz. locally I see the errors as well.
So if you give it a string literal, it will always complain.
but if you pass in a string, it works: to={"https://" as string}

[micah-redwood]

Ah, interesting, would not have expected that.

I still think it'd be a bit more clear to have a different prop but this is a fine workaround for now. Really appreciate your help with this!

[schiller-manuel]

yes this is more of a "currently you can workaround using this". but we could think of using href as a signal to opt out of any typesafety and just use its value as the href for the underyling <a>