Skip to content

docs: add vite preview to start e2e/examples #5918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2025
Merged

docs: add vite preview to start e2e/examples #5918

merged 2 commits into from
Nov 20, 2025
+50 −1

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Nov 20, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Added a preview script across example and e2e projects to enable a local preview server via npm run preview.

  • Build Improvements

    • Updated build in select example projects to run TypeScript type-checking as part of the build.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 20, 2025 •
edited
Loading

Walkthrough

Added a "preview": "vite preview" npm script to many e2e and example package.json files; one package.json (examples/solid/start-basic-static/package.json) also updated its build script to run tsc --noEmit after vite build.

Changes

Cohort / File(s) Summary
E2E — React start packages
e2e/react-start/*/package.json (multiple files, e.g. basic-auth, basic-react-query, custom-basepath, query-integration, scroll-restoration, selective-ssr, serialization-adapters, server-functions, server-routes, spa-mode, virtual-routes, website)		 Added "preview": "vite preview" to scripts
E2E — Solid start packages
e2e/solid-start/*/package.json (multiple files, e.g. basic-auth, basic-solid-query, custom-basepath, query-integration, scroll-restoration, selective-ssr, serialization-adapters, server-functions, server-routes, spa-mode, virtual-routes, website)		 Added "preview": "vite preview" to scripts
Examples — React
examples/react/*/package.json (multiple files, e.g. start-bare, start-basic-auth, start-basic-react-query, start-basic-static, start-basic, start-clerk-basic, start-convex-trellaux, start-counter, start-large, start-material-ui, start-streaming-data-from-server-functions, start-supabase-basic, start-tailwind-v4, start-trellaux, start-workos)		 Added "preview": "vite preview" to scripts
Examples — Solid
examples/solid/*/package.json (multiple files, e.g. start-basic-auth, start-basic-solid-query, start-basic-static, start-basic, start-convex-better-auth, start-counter, start-large, start-streaming-data-from-server-functions, start-supabase-basic, start-tailwind-v4)		 Added "preview": "vite preview" to scripts; examples/solid/start-basic-static/package.json also changed build to vite build && tsc --noEmit

Sequence Diagram(s)

No sequence diagram — changes are script additions only and do not modify runtime control flow.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Homogeneous, repetitive edits across many package.json files.
  • Pay attention to:
    • examples/solid/start-basic-static/package.json (build script changed to include tsc --noEmit).
    • Any package.json that may already have a conflicting preview or start script (verify no unintended overwrites).

Possibly related PRs

Suggested labels

documentation

Poem

🐇 I hopped through package files today,

added preview so you can play,
one build now checks types along the way,
tiny changes, bright as May! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding a 'vite preview' script to multiple package.json files across e2e and examples directories.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore--add-vite-preview-to-start-e2e/examples
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 41da65b and f815acc.

📒 Files selected for processing (4)
  • e2e/react-start/basic-auth/package.json (1 hunks)
  • e2e/solid-start/basic-auth/package.json (1 hunks)
  • examples/react/start-basic-auth/package.json (1 hunks)
  • examples/solid/start-basic-auth/package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • e2e/react-start/basic-auth/package.json
  • e2e/solid-start/basic-auth/package.json
  • examples/solid/start-basic-auth/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Preview
  • GitHub Check: Test
🔇 Additional comments (1)
examples/react/start-basic-auth/package.json (1)

9-9: LGTM! Adds standard Vite preview workflow.

Adding the "preview" script enables developers to locally test the production build—a helpful addition to the standard dev → build → preview Vite workflow. The script uses the correct vite preview command, vite is already a devDependency, and the placement aligns with the existing scripts section.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Nov 20, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit f815acc

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 42s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-20 04:23:27 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 20, 2025 •
edited
Loading

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5918

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5918

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5918

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5918

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5918

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5918

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5918

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5918

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5918

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5918

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5918

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5918

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5918

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5918

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5918

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5918

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5918

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5918

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5918

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5918

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5918

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5918

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5918

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5918

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5918

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5918

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5918

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5918

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5918

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5918

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5918

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5918

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5918

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5918

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5918

commit: f815acc

@birkskyum birkskyum merged commit f139f1e into main Nov 20, 2025
6 checks passed
@birkskyum birkskyum deleted the chore--add-vite-preview-to-start-e2e/examples branch November 20, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@birkskyum