Skip to content

Conversation

@LadyBluenotes
Copy link
Contributor

@LadyBluenotes LadyBluenotes commented Nov 21, 2025

Prepping docs for a new markdown change :))))

Summary by CodeRabbit

  • Documentation
    • Enhanced documentation formatting across framework guides to improve readability and visual clarity. Updated note formatting and content structure provide a better user experience when reading guides.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions github-actions bot added the documentation Everything documentation related label Nov 21, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 21, 2025

Walkthrough

This PR reformats Markdown admonition blocks and notes across six documentation files, converting inline single-line blocks to blockquote-style multi-line format with explicit line breaks. No content, semantics, or functionality changes are introduced.

Changes

Cohort / File(s) Summary
Router React Documentation
docs/router/framework/react/how-to/setup-ssr.md, docs/router/framework/react/llm-support.md, docs/router/framework/react/quick-start.md, docs/router/framework/react/routing/file-naming-conventions.md
Reformat admonition blocks ([!NOTE], [!TIP]) from inline single-line format to multi-line blockquote style with explicit line breaks and spacing
Start Framework Documentation
docs/start/framework/react/build-from-scratch.md, docs/start/framework/solid/build-from-scratch.md
Split [!NOTE] blocks into multi-line blockquote format, converting single-line notes into two-line blocks with added blank lines for spacing

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

The changes are highly repetitive and homogeneous in nature (consistent formatting pattern applied across multiple files), reducing cognitive overhead despite the number of affected files. Each file change follows the same conversion pattern.

Possibly related PRs

Suggested reviewers

  • schiller-manuel
  • birkskyum

Poem

🐰 Hop along, dear docs so neat,
Blockquotes now make formatting sweet,
Line breaks bloom in rows so clear,
Notes reshape—the truth stays here!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly and concisely describes the main change: reformatting documentation callouts (admonitions/notes) to place content on new lines. The title accurately reflects all six modified documentation files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3af4b8 and 97dbab5.

📒 Files selected for processing (6)
  • docs/router/framework/react/how-to/setup-ssr.md (2 hunks)
  • docs/router/framework/react/llm-support.md (1 hunks)
  • docs/router/framework/react/quick-start.md (2 hunks)
  • docs/router/framework/react/routing/file-naming-conventions.md (1 hunks)
  • docs/start/framework/react/build-from-scratch.md (2 hunks)
  • docs/start/framework/solid/build-from-scratch.md (2 hunks)
🧰 Additional context used
🧠 Learnings (6)
📚 Learning: 2025-10-14T18:59:33.990Z
Learnt from: FatahChan
Repo: TanStack/router PR: 5475
File: e2e/react-start/basic-prerendering/src/routes/redirect/$target/via-beforeLoad.tsx:8-0
Timestamp: 2025-10-14T18:59:33.990Z
Learning: In TanStack Router e2e test files, when a route parameter is validated at the route level (e.g., using zod in validateSearch or param validation), switch statements on that parameter do not require a default case, as the validation ensures only expected values will reach the switch.

Applied to files:

  • docs/router/framework/react/quick-start.md
📚 Learning: 2025-09-22T00:56:49.237Z
Learnt from: nlynzaad
Repo: TanStack/router PR: 5182
File: e2e/react-router/basic-file-based/src/routes/non-nested/named/$baz_.bar.tsx:3-5
Timestamp: 2025-09-22T00:56:49.237Z
Learning: In TanStack Router, underscores are intentionally stripped from route segments (e.g., `$baz_` becomes `baz` in generated types) but should be preserved in base path segments. This is the correct behavior as of the fix in PR #5182.

Applied to files:

  • docs/router/framework/react/routing/file-naming-conventions.md
📚 Learning: 2025-09-22T00:56:53.426Z
Learnt from: nlynzaad
Repo: TanStack/router PR: 5182
File: e2e/react-router/basic-file-based/tests/non-nested-paths.spec.ts:167-172
Timestamp: 2025-09-22T00:56:53.426Z
Learning: In TanStack Router, underscores are intentionally stripped from route segments during path parsing, but preserved in base path segments. This is the expected behavior implemented in PR #5182.

Applied to files:

  • docs/router/framework/react/routing/file-naming-conventions.md
📚 Learning: 2025-10-08T08:11:47.088Z
Learnt from: nlynzaad
Repo: TanStack/router PR: 5402
File: packages/router-generator/tests/generator/no-formatted-route-tree/routeTree.nonnested.snapshot.ts:19-21
Timestamp: 2025-10-08T08:11:47.088Z
Learning: Test snapshot files in the router-generator tests directory (e.g., files matching the pattern `packages/router-generator/tests/generator/**/routeTree*.snapshot.ts` or `routeTree*.snapshot.js`) should not be modified or have issues flagged, as they are fixtures used to verify the generator's output and are intentionally preserved as-is.

Applied to files:

  • docs/router/framework/react/routing/file-naming-conventions.md
📚 Learning: 2025-09-28T21:41:45.233Z
Learnt from: nlynzaad
Repo: TanStack/router PR: 5284
File: e2e/react-start/basic/server.js:50-0
Timestamp: 2025-09-28T21:41:45.233Z
Learning: In Express v5, catch-all routes must use named wildcards. Use `/*splat` to match everything except root path, or `/{*splat}` (with braces) to match including root path. The old `*` syntax is not allowed and will cause "Missing parameter name" errors. This breaking change requires explicit naming of wildcard parameters.

Applied to files:

  • docs/router/framework/react/routing/file-naming-conventions.md
📚 Learning: 2025-11-02T16:16:24.898Z
Learnt from: nlynzaad
Repo: TanStack/router PR: 5732
File: packages/start-client-core/src/client/hydrateStart.ts:6-9
Timestamp: 2025-11-02T16:16:24.898Z
Learning: In packages/start-client-core/src/client/hydrateStart.ts, the `import/no-duplicates` ESLint disable is necessary for imports from `#tanstack-router-entry` and `#tanstack-start-entry` because both aliases resolve to the same placeholder file (`fake-start-entry.js`) in package.json during static analysis, even though they resolve to different files at runtime.

Applied to files:

  • docs/router/framework/react/how-to/setup-ssr.md
🪛 markdownlint-cli2 (0.18.1)
docs/router/framework/react/llm-support.md

28-28: Blank line inside blockquote

(MD028, no-blanks-blockquote)

🔇 Additional comments (5)
docs/router/framework/react/quick-start.md (1)

21-22: Formatting changes look good.

Both callout blocks properly reformatted to blockquote-style, consistent with the PR's objective to format callouts on new lines.

Also applies to: 64-65

docs/start/framework/solid/build-from-scratch.md (1)

25-26: Formatting changes consistent and correct.

Both NOTE blocks properly converted to blockquote-style admonitions, maintaining content integrity.

Also applies to: 46-47

docs/router/framework/react/routing/file-naming-conventions.md (1)

22-23: Proper blockquote reformatting.

The NOTE block correctly converted to blockquote-style while preserving the important technical guidance about escaping trailing underscores.

docs/start/framework/react/build-from-scratch.md (1)

27-28: Formatting changes correct and consistent.

Both NOTE blocks properly converted to blockquote-style format, maintaining content accuracy.

Also applies to: 47-48

docs/router/framework/react/how-to/setup-ssr.md (1)

5-6: Blockquote reformatting properly applied.

Both callout blocks (IMPORTANT and TIP) correctly converted to multi-line blockquote format with content on separate lines, as per the PR objective. Bold formatting and content integrity preserved.

Also applies to: 427-428


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Nov 21, 2025

View your CI Pipeline Execution ↗ for commit 97dbab5

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-21 05:17:03 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 21, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5927

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5927

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5927

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5927

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5927

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5927

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5927

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5927

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5927

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5927

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5927

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5927

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5927

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5927

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5927

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5927

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5927

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5927

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5927

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5927

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5927

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5927

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5927

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5927

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5927

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5927

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5927

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5927

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5927

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5927

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5927

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5927

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5927

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5927

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5927

commit: 97dbab5

@birkskyum birkskyum merged commit bc79c97 into TanStack:main Nov 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Everything documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants