wip: skipBaseProperties skip properties that ends with Handler

Author: riccardoperra

packages/angular-table/src/angularReactivityFeature.ts

@@ -130,21 +130,14 @@ export const angularReactivityFeature = constructAngularReactivityFeature()
 
 function skipBaseProperties(property: string): boolean {
   return (
-    // equal `getContext`
+    // equals `getContext`
     property === 'getContext' ||
     // start with `_`
     property[0] === '_' ||
-    // start with `get`
+    // doesn't start with `get`
     !(property[0] === 'g' && property[1] === 'e' && property[2] === 't') ||
     // ends with `Handler`
-    (property.length >= 7 &&
-      property[property.length - 7] === 'H' &&
-      property[property.length - 6] === 'a' &&
-      property[property.length - 5] === 'n' &&
-      property[property.length - 4] === 'd' &&
-      property[property.length - 3] === 'l' &&
-      property[property.length - 2] === 'e' &&
-      property[property.length - 1] === 'r')
+    property.endsWith('Handler')
   )
 }
 

packages/angular-table/tests/benchmarks/injectTable.benchmark.ts

@@ -5,11 +5,11 @@ import { benchCases, columns, createTestTable, dataMap } from './setup'
 const nIteration = 5
 
 for (const benchCase of benchCases) {
-  describe(`injectTable (${benchCase.size} elements)`, () => {
+  describe(`injectTable - ${benchCase.size} elements`, () => {
     const data = dataMap[benchCase.size]!
 
     bench(
-      `${benchCase.size} elements - No reactivity`,
+      `No reactivity`,
       async () => {
         const table = createTestTable(false, data, columns)
         await setTimeout(0)
@@ -21,7 +21,7 @@ for (const benchCase of benchCases) {
     )
 
     bench(
-      `${benchCase.size} Enabled reactivity`,
+      `Full reactivity`,
       async () => {
         const table = createTestTable(true, data, columns)
         await setTimeout(0)