fix tests, cleanup code

Author: riccardoperra

packages/angular-table/src/flex-render.ts

@@ -73,7 +73,6 @@ export class FlexRenderDirective<TProps extends NonNullable<unknown>>
   ) {}
 
   ngOnChanges(changes: SimpleChanges) {
-    console.log('changes', changes)
     if (changes['content']) {
       this.renderFlags |= FlexRenderFlags.ContentChanged
     }
@@ -101,7 +100,7 @@ export class FlexRenderDirective<TProps extends NonNullable<unknown>>
     const contentToRender = this.#getContentValue(this.props)
 
     if (contentToRender.kind === 'null' || !this.renderView) {
-      this.renderFlags = FlexRenderFlags.Creation
+      this.renderFlags |= FlexRenderFlags.Creation
     } else {
       this.renderView.setContent(contentToRender.content)
       const previousContentInfo = this.renderView.previousContent

packages/angular-table/src/flex-render/flags.ts

@@ -4,20 +4,20 @@ export enum FlexRenderFlags {
    */
   Creation = 1 << 0,
   /**
-   * Whether the `content` property has changed or the view need a complete re-rendering.
+   * Indicates that the `content` property has changed or the view need a complete re-rendering.
    * When this flag is enabled, the view is recreated from scratch after clearing the previous one.
    */
   ContentChanged = 1 << 1,
   /**
-   * Whether the `props` property reference has changed.
+   * Indicates that the `props` property reference has changed.
    * When this flag is enabled, the view context is updated based on the type of the content.
    *
    * For Component view, inputs will be updated and view will be marked as dirty.
    * For TemplateRef and primitive values, view will be marked as dirty
    */
   PropsReferenceChanged = 1 << 2,
   /**
-   * Whether the current rendered view has to be dirty checked.
+   * Indicates the current rendered view has to be dirty checked.
    */
   DirtyCheck = 1 << 3,
 }

packages/angular-table/src/flex-render/flex-render-component-ref.ts

@@ -68,15 +68,15 @@ export class FlexRenderComponentRef<T> {
    *
    * @param compare Whether the current ref component instance is the same as the given one
    */
-  eq(compare: FlexRenderComponent<T>): boolean {
+  eqType(compare: FlexRenderComponent<T>): boolean {
     return compare.component === this.component
   }
 
   /**
    * Tries to update current component refs input by the new given content component.
    */
   update(content: FlexRenderComponent<T>) {
-    const eq = this.eq(content)
+    const eq = this.eqType(content)
     if (!eq) return
     const changes = this.diff(content)
     if (!changes) return

packages/angular-table/src/flex-render/view.ts

@@ -87,9 +87,12 @@ export class FlexRenderTemplateView extends FlexRenderView<
   }
 
   override dirtyCheck() {
-    // Basically a no-op. Currently in all of those cases, we don't need to do any manual update
-    // since this type of content is rendered with an EmbeddedViewRef with a proxy as a context,
-    // then every time the root component is checked for changes, the getter will be re-evaluated.
+    // Basically a no-op. When the view is created via EmbeddedViewRef, we don't need to do any manual update
+    // since this type of content has a proxy as a context, then every time the root component is checked for changes,
+    // the property getter will be re-evaluated.
+    //
+    // If in a future we need to manually mark the view as dirty, just uncomment next line
+    // this.view.markForCheck()
   }
 }
 
@@ -110,13 +113,16 @@ export class FlexRenderComponentView extends FlexRenderView<
   override dirtyCheck() {
     switch (this.content.kind) {
       case 'component': {
+        // Component context is currently valuated with the cell context. Since it's reference
+        // shouldn't change, we force mark the component as dirty in order to re-evaluate function invocation in view.
+        // NOTE: this should behave like having a component with ChangeDetectionStrategy.Default
         this.view.markAsDirty()
         break
       }
       case 'flexRenderComponent': {
-        // the given content instance will always have a different reference that previous one,
-        // then in that case instead of recreating the entire view, we will only update what changes
-        if (this.view.eq(this.content.content)) {
+        // Given context instance will always have a different reference than the previous one,
+        // so instead of recreating the entire view, we will only update the current view
+        if (this.view.eqType(this.content.content)) {
           this.view.update(this.content.content)
         }
         break

packages/angular-table/tests/createAngularTable.test.ts

@@ -7,7 +7,7 @@ import {
 } from '../src/index'
 import { Component, input, isSignal, signal, untracked } from '@angular/core'
 import { TestBed } from '@angular/core/testing'
-import { setSignalInputs } from './test-utils'
+import { setFixtureSignalInputs } from './test-utils'
 
 describe('createAngularTable', () => {
   test('should render with required signal inputs', () => {
@@ -27,7 +27,7 @@ describe('createAngularTable', () => {
     }
 
     const fixture = TestBed.createComponent(FakeComponent)
-    setSignalInputs(fixture.componentInstance, {
+    setFixtureSignalInputs(fixture, {
       data: [],
     })
 

packages/angular-table/tests/test-utils.ts

@@ -8,27 +8,14 @@ type ToSignalInputUpdatableMap<T> = {
     : never]: T[K] extends InputSignal<infer Value> ? Value : never
 }
 
-/**
- * Set required signal input value to component fixture
- * @see https://github.com/angular/angular/issues/54013
- */
-export function setSignalInputs<T extends NonNullable<unknown>>(
-  component: T,
-  inputs: ToSignalInputUpdatableMap<T>
-) {
-  for (const inputKey in inputs) {
-    if (componentHasSignalInputProperty(component, inputKey)) {
-      signalSetFn(component[inputKey][SIGNAL], inputs[inputKey])
-    }
-  }
-}
-
 export function setFixtureSignalInputs<T extends NonNullable<unknown>>(
   componentFixture: ComponentFixture<T>,
   inputs: ToSignalInputUpdatableMap<T>,
   options: { detectChanges: boolean } = { detectChanges: true }
 ) {
-  setSignalInputs(componentFixture.componentInstance, inputs)
+  for (const inputKey in inputs) {
+    componentFixture.componentRef.setInput(inputKey, inputs[inputKey])
+  }
   if (options.detectChanges) {
     componentFixture.detectChanges()
   }
@@ -43,7 +30,7 @@ export function setFixtureSignalInput<
   inputName: InputName,
   value: InputMaps[InputName]
 ) {
-  setSignalInputs(componentFixture.componentInstance, {
+  setFixtureSignalInputs(componentFixture, {
     [inputName]: value,
   } as ToSignalInputUpdatableMap<T>)
 }