Skip to content

Commit db39511

Browse files
committed
improve view flags, handle state update in zoneless
1 parent 9d57db0 commit db39511

File tree

1 file changed

+6
-29
lines changed

1 file changed

+6
-29
lines changed

packages/angular-table/src/flex-render.ts

Lines changed: 6 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -112,26 +112,17 @@ export class FlexRenderDirective<TProps extends NonNullable<unknown>>
112112
return
113113
}
114114

115-
console.log('go into do check')
116-
117-
// TODO: Optimization for V9 / future updates?. We could check for dirty signal changes when
118-
// we are able to detect whether the table state changes here
119-
// const isChanged =
115+
// TODO: Optimization for V9 / future updates?.
116+
// We could check for dirty signal changes when we are able to detect whether the table state changes here
117+
// const isChanged =
120118
// this.renderFlags &
121119
// (FlexRenderFlags.DirtySignal | FlexRenderFlags.PropsReferenceChanged)
122-
// if (!isChanged) {
123-
// return
124-
// }
125-
// if (this.renderFlags & FlexRenderFlags.DirtySignal) {
126-
// this.renderFlags &= ~FlexRenderFlags.DirtySignal
127-
// return
128-
// }
120+
// if (!isChanged) {
121+
// return
122+
// }
129123

130124
this.renderFlags |= FlexRenderFlags.DirtyCheck
131-
this.checkViewChanges()
132-
}
133125

134-
checkViewChanges(): void {
135126
const latestContent = this.#getContentValue()
136127
if (latestContent.kind === 'null' || !this.renderView) {
137128
this.renderFlags |= FlexRenderFlags.ContentChanged
@@ -298,17 +289,3 @@ export class FlexRenderDirective<TProps extends NonNullable<unknown>>
298289
return new FlexRenderComponentView(component, view)
299290
}
300291
}
301-
302-
function logFlags(place: string, flags: FlexRenderFlags, val: any) {
303-
console.group(`${place}`, val)
304-
const result = {} as Record<string, boolean>
305-
for (const key in FlexRenderFlags) {
306-
// Skip the reverse mapping of numeric values to keys in enums
307-
if (isNaN(Number(key))) {
308-
const flagValue = FlexRenderFlags[key as keyof typeof FlexRenderFlags]
309-
console.log(key, !!(flags & flagValue))
310-
}
311-
}
312-
console.groupEnd()
313-
return result
314-
}

0 commit comments

Comments
 (0)