Rows not resetting after removing filter

[martitv]

Hi, I've created a custom filter that is supposed to hide rows with the given values:

function hideStatusFilter(
  rows: Row<Task>[],
  columnIds: string[],
  filterValues: string[]
) {
  return rows.filter(
    (row) =>
      !columnIds.some((columnId) =>
        filterValues?.includes(row.values[columnId])
      )
  );
}

hideStatusFilter.autoRemove = (val: any) => !val || val.length === 0;

I added the filter to my column like so:

const columns = [
       ...,
      {
        Header: 'Status',
        accessor: 'status',
        filter: hideStatusFilter,
      },
      ...,
];

I apply the filter using a checkbox outside the table like so:

//setFilter is from the useTable instance

          onChange={(e) =>
            e.target.checked
              ? setFilter('status', undefined)
              : setFilter('status', ['Finished', 'Suggested']

The problem is that when i check the box after having unchecked it, the table remains filtered. It still wont show rows with Status = Finished or Suggested.
I have verified that the filter is actually removed using state.filters from the useTable instance.

E.g
Table initially(after a page refresh):

• Show non-active statuses

Title	Status
Task1	Active
Task2	Active
Task3	Suggested
Task4	Finished
Task5	Finished

Table when unchecked:

• Show non-active statuses

Title	Status
Task1	Active
Task2	Active

Table when checked again(this is the problem):

• Show non-active statuses

Title	Status
Task1	Active
Task2	Active

I assume this is because the rows that are passed into the filter function are the already filtered ones meaning i will only ever be able to return the already filtered rows from my custom filter function. I assumed react-table would just render all rows if no filter was applied?

What am i doing wrong here?

EDIT:
After some tinkering in codesandbox it seems like the issue lies with filters and subrows. If a filter hides subrows but not the parentrow, the hidden subrows will not be displayed again after removing the filter
See: https://codesandbox.io/s/floral-cookies-f7k8u?file=/src/App.js

Is this perhaps relevant to this issue? #2064

[martitv]

My example wasn't fully fleshed out. The issue seems to lie with subRows. Subrows are disappearing after filtering.
Se this sandbox: https://codesandbox.io/s/floral-cookies-f7k8u?file=/src/App.js

Try to collapse and expand the rows with the filters applied.
After this, if parentrow had active status, subrows with finished/suggested status will not be displayed regardless of whether the filters are applied or not.

Any ideas @tannerlinsley ?