ColumnResizerProps TouchEvent/MouseEvent types

[promontis]

ColumnResizerProps is defined like this..

export declare type ColumnResizerProps = {
    title?: string;
    onMouseDown?: (e: MouseEvent) => void;
    onTouchStart?: (e: TouchEvent) => void;
    draggable?: boolean;
    role?: string;
};

I think it should be...

export declare type ColumnResizerProps = {
    title?: string;
    onMouseDown?: (e: MouseEvent<HTMLElement>) => void;
    onTouchStart?: (e: TouchEvent<HTMLElement>) => void;
    draggable?: boolean;
    role?: string;
};

So that the client code can become...

 <div {...header.getResizerProps((props: ColumnResizerProps) => ({

instead of ...

 <div {...header.getResizerProps((props: any) => ({

[promontis]

If this is ok, I can create a PR

[tannerlinsley]

I don’t see the benefit. Can you explain more why they need to change? Tanner Linsley

…

On Apr 6, 2022, 6:21 AM -0600, Michel van den Berg ***@***.***>, wrote: If this is ok, I can create a PR — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[nrayburn-tech]

It's likely there are other ways around this or I am missing something, but my use case is being able to spread the return value directly to a component, like Box from Material UI.

Modified resizing example to add Material UI box. https://codesandbox.io/s/nifty-meitner-9sg157?file=/src/main.tsx