[v8] Is there a Typescript regression?

[kosciak9]

Hello,

Updating to v8.5.6 fails our type checks - apparently our way of defining columns is wrong:

const columnHelper = createColumnHelper<Transaction>();

const columns = [
  columnHelper.accessor("date", {
    header: () => "Data",
  }),
  columnHelper.accessor("title", {
    header: () => "Tytuł",
  }),
  columnHelper.accessor(
    (row) => `${row.amount ?? 0} ${row.currency?.symbol ?? ""}`,
    {
      id: "amountDisplay",
      header: () => "Kwota",
    }
  ),

We are not using ColumnDef as Typescript properly inferred types from current revision of code and everything was working properly. Is this something that we should change? Or is there unwanted regression?

[tannerlinsley]

Working on a fix Tanner Linsley

…

On Aug 4, 2022, 8:19 AM -0600, Franek Madej ***@***.***>, wrote: Hello, Updating to v8.5.6 fails our type checks - apparently our way of defining columns is wrong: const columnHelper = createColumnHelper<Transaction>(); const columns = [ columnHelper.accessor("date", { header: () => "Data", }), columnHelper.accessor("title", { header: () => "Tytuł", }), columnHelper.accessor( (row) => `${row.amount ?? 0} ${row.currency?.symbol ?? ""}`, { id: "amountDisplay", header: () => "Kwota", } ), We are not using ColumnDef as Typescript properly inferred types from current revision of code and everything was working properly. Is this something that we should change? Or is there unwanted regression? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[kosciak9]

Amazing, then we're gonna hold updating for now