Replies: 1 comment
-
Went ahead and created a PR to add the feature |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Hi,
I've been using v7 and more recently started switching to v8. I have to say I'm loving the DX and most importantly the performance (no more
prepareRow()
<3)., kudos for that!The question: in v7 I had implemented a plugin to pick/unpick rows. This is different from selection as selected rows might not be the ones I picked. I'm using that table to preview the data to import through a CSV file and by picking/unpicking rows the user can select which rows to skip (by default all would be picked). Checkboxes are used on the leftmost column to pick/unpick rows.
Having said that, what would be the best way to extend the functionality of react-table v8?
I'd like to still have methods such as
getRowPickedModel()
androw.getIsPicked()
for example.Maybe allowing to pass custom features which implement
TableFeature
? This would be similar to have a "plugin system", no?https://github.com/TanStack/table/blob/606dfe224ec596c425a8a1725cf623cdbc0662a8/packages/table-core/src/core/table.ts#LL96C32-L96C32
Or: I think I could contribute with a PR for adding
RowPicking
as a core feature. Would there be an interest for this? The code should be pretty similar toRowSelection
, same/similar logic but separate state.Thanks!
Beta Was this translation helpful? Give feedback.
All reactions