Merge pull request #53 from Tanq16/bundlefixes

Deploy New Version

Author: Tanq16

README.md

@@ -202,6 +202,10 @@ If setting up for the first time, an environment variable can be used for ease.
 CURRENCY=eur ./expenseowl
 ```
 
+> [!NOTE]
+> Expense Owl primarily supports using positive values for all expenses by default. For better imports and higher control, ExpenseOwl also allows for negative values (see https://github.com/Tanq16/ExpenseOwl/pull/39). As such, positive expenses indicate money spent, while negative expenses indicate money gained, i.e., a return or reimbursment.
+> Various software deal with positive and negative expenses differently. This project aims to provide freedom in operation, as a result of which a future refactor will allow for a choice for accurate external imports. 
+
 ExpenseOwl also supports custom categories. A default set is pre-loaded in the config for ease of use and can be easily changed within the UI.
 
 Like currency, if setting up for the first time, categories can be specified in an environment variable like so:

internal/api/import-export.go

@@ -163,7 +163,7 @@ func (h *Handler) ImportCSV(w http.ResponseWriter, r *http.Request) {
 		}
 		// Handle amount (skipping regex since parsing as float)
 		amount, err := strconv.ParseFloat(strings.TrimSpace(record[amountIdx]), 64)
-		if err != nil || amount <= 0 {
+		if err != nil {
 			log.Printf("Warning: Skipping row %d due to invalid amount: %s\n", i, record[amountIdx])
 			continue
 		}

internal/config/config.go

@@ -86,9 +86,6 @@ func (e *Expense) Validate() error {
 	if e.Category == "" {
 		return errors.New("category is required")
 	}
-	if e.Amount <= 0 {
-		return errors.New("amount must be greater than 0")
-	}
 	return nil
 }
 

internal/web/templates/index.html

@@ -86,7 +86,7 @@
 
                 <div class="form-group">
                     <label for="amount">Amount</label>
-                    <input type="number" id="amount" step="0.01" min="0.01" required>
+                    <input type="number" id="amount" step="0.01" required>
                 </div>
 
                 <div class="form-group">
@@ -354,9 +354,6 @@
         // Update month display and navigation buttons
         function updateMonthDisplay() {
             document.getElementById('currentMonth').textContent = formatMonth(currentDate);
-            const now = new Date();
-            const isCurrentMonth = currentDate.getMonth() === now.getMonth() && currentDate.getFullYear() === now.getFullYear();
-            document.getElementById('nextMonth').disabled = isCurrentMonth;
         }
         // Get start and end of month
         function getMonthBounds(date) {
@@ -490,6 +487,13 @@
             }
         });
         document.addEventListener('DOMContentLoaded', initialize);
+
+        // event listener to remove the - from the name input when the user clicks on the input
+        document.getElementById('name').addEventListener('click', (e) => {
+            if (e.target.value === '-') {
+                e.target.value = '';
+            }
+        });
     </script>
 </body>
 </html>

internal/web/templates/table.html

@@ -49,7 +49,7 @@
 
                 <div class="form-group">
                     <label for="amount">Amount</label>
-                    <input type="number" id="amount" step="0.01" min="0.01" required>
+                    <input type="number" id="amount" step="0.01" required>
                 </div>
 
                 <div class="form-group">
@@ -137,9 +137,6 @@ <h3>Delete Expense</h3>
 
         function updateMonthDisplay() {
             document.getElementById('currentMonth').textContent = formatMonth(currentDate);
-            const now = new Date();
-            const isCurrentMonth = currentDate.getMonth() === now.getMonth() && currentDate.getFullYear() === now.getFullYear();
-            document.getElementById('nextMonth').disabled = isCurrentMonth;
         }
         function getMonthBounds(date) {
             const localDate = new Date(date);
@@ -383,6 +380,13 @@ <h3>Delete Expense</h3>
             }
         });
         document.addEventListener('DOMContentLoaded', initialize);
+
+        // event listener to remove the - from the name input when the user clicks on the input
+        document.getElementById('name').addEventListener('click', (e) => {
+            if (e.target.value === '-') {
+                e.target.value = '';
+            }
+        });
     </script>
 </body>
 </html>