Skip to content

Commit 15d8410

Browse files
committed
In configuration settings of the ChakraCore JS engine was changed default value of DisableFatalOnOOM property from false to true
1 parent b8d573e commit 15d8410

File tree

6 files changed

+8
-11
lines changed

6 files changed

+8
-11
lines changed

global.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"sdk": {
3-
"version": "2.2.105"
3+
"version": "2.2.106"
44
}
55
}

src/JavaScriptEngineSwitcher.ChakraCore/ChakraCoreSettings.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ public ChakraCoreSettings()
140140
DisableBackgroundWork = false;
141141
DisableEval = false;
142142
DisableExecutablePageAllocation = false;
143-
DisableFatalOnOOM = false;
143+
DisableFatalOnOOM = true;
144144
DisableNativeCodeGeneration = false;
145145
EnableExperimentalFeatures = false;
146146
#if !NETSTANDARD1_3

src/JavaScriptEngineSwitcher.ChakraCore/JavaScriptEngineSwitcher.ChakraCore.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ This package does not contain the native implementations of ChakraCore. Therefor
2222
* JavaScriptEngineSwitcher.ChakraCore.Native.osx-x64</Description>
2323
<PackageIconUrl>https://raw.githubusercontent.com/Taritsyn/JavaScriptEngineSwitcher/master/Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconUrl>
2424
<PackageTags>JavaScriptEngineSwitcher;JavaScript;ECMAScript;ChakraCore</PackageTags>
25-
<PackageReleaseNotes>ChakraCore was updated to version 1.11.8.</PackageReleaseNotes>
25+
<PackageReleaseNotes>In configuration settings of the ChakraCore JS engine was changed default value of `DisableFatalOnOOM` property from `false` to `true`.</PackageReleaseNotes>
2626
</PropertyGroup>
2727

2828
<Import Project="../../build/common.props" />

src/JavaScriptEngineSwitcher.ChakraCore/readme.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@
3030
=============
3131
RELEASE NOTES
3232
=============
33-
ChakraCore was updated to version 1.11.8.
33+
In configuration settings of the ChakraCore JS engine was changed default value
34+
of `DisableFatalOnOOM` property from `false` to `true`.
3435

3536
=============
3637
DOCUMENTATION

test/JavaScriptEngineSwitcher.Tests/ChakraCore/CommonTests.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -200,8 +200,7 @@ public void MappingRuntimeErrorDuringOutOfMemoryIsCorrect()
200200
using (IJsEngine jsEngine = new ChakraCoreJsEngine(
201201
new ChakraCoreSettings
202202
{
203-
MemoryLimit = new UIntPtr(2 * 1024 * 1024),
204-
DisableFatalOnOOM = true
203+
MemoryLimit = new UIntPtr(2 * 1024 * 1024)
205204
}
206205
))
207206
{
@@ -234,8 +233,7 @@ public void MappingEngineLoadErrorDuringOutOfMemoryIsCorrect()
234233
jsEngine = new ChakraCoreJsEngine(
235234
new ChakraCoreSettings
236235
{
237-
MemoryLimit = new UIntPtr(8 * 1024),
238-
DisableFatalOnOOM = true
236+
MemoryLimit = new UIntPtr(8 * 1024)
239237
}
240238
);
241239
}

test/JavaScriptEngineSwitcher.Tests/MultithreadingTestsBase.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
using System;
2-
using System.IO;
3-
using System.Threading;
1+
using System.Threading;
42

53
using Xunit;
64

0 commit comments

Comments
 (0)