Skip to content

Commit 3cf5442

Browse files
committed
In JavaScriptEngineSwitcher.ChakraCore fixed a error causing a crash during finalization
1 parent 829d9de commit 3cf5442

File tree

3 files changed

+2
-21
lines changed

3 files changed

+2
-21
lines changed

NuGet/JavaScriptEngineSwitcher.ChakraCore/JavaScriptEngineSwitcher.ChakraCore.nuspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ This package does not contain the native implementations of ChakraCore. Therefor
2020
* JavaScriptEngineSwitcher.ChakraCore.Native.debian-x64
2121
* JavaScriptEngineSwitcher.ChakraCore.Native.osx-x64</description>
2222
<summary>JavaScriptEngineSwitcher.ChakraCore contains adapter `ChakraCoreJsEngine` (wrapper for the ChakraCore).</summary>
23-
<releaseNotes>ChakraCore was updated to version 1.4.1.</releaseNotes>
23+
<releaseNotes>Fixed a error causing a crash during finalization.</releaseNotes>
2424
<copyright>Copyright (c) 2013-2017 Andrey Taritsyn - http://www.taritsyn.ru</copyright>
2525
<language>en-US</language>
2626
<tags>JavaScriptEngineSwitcher JavaScript ECMAScript ChakraCore</tags>

NuGet/JavaScriptEngineSwitcher.ChakraCore/readme.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
=============
3131
RELEASE NOTES
3232
=============
33-
ChakraCore was updated to version 1.4.1.
33+
Fixed a error causing a crash during finalization.
3434

3535
=============
3636
DOCUMENTATION

src/JavaScriptEngineSwitcher.ChakraCore/ScriptDispatcher.cs

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -68,14 +68,6 @@ public ScriptDispatcher()
6868
_thread.Start();
6969
}
7070

71-
/// <summary>
72-
/// Destructs an instance of script dispatcher
73-
/// </summary>
74-
~ScriptDispatcher()
75-
{
76-
Dispose(false);
77-
}
78-
7971

8072
private void VerifyNotDisposed()
8173
{
@@ -213,17 +205,6 @@ public void Invoke(Action action)
213205
/// Destroys object
214206
/// </summary>
215207
public void Dispose()
216-
{
217-
Dispose(true /* disposing */);
218-
GC.SuppressFinalize(this);
219-
}
220-
221-
/// <summary>
222-
/// Destroys object
223-
/// </summary>
224-
/// <param name="disposing">Flag, allowing destruction of
225-
/// managed objects contained in fields of class</param>
226-
private void Dispose(bool disposing)
227208
{
228209
if (_disposedFlag.Set())
229210
{

0 commit comments

Comments
 (0)