Skip to content

Commit 3faa7ae

Browse files
committed
In NuGet packages specified PackageIconUrl in addition to PackageIcon
1 parent 1682d35 commit 3faa7ae

File tree

22 files changed

+50
-29
lines changed

22 files changed

+50
-29
lines changed

build/initialize-standard-nuspec-properties.targets

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
</_TagsElement>
6666

6767
<_IconUrlElement/>
68-
<_IconUrlElement Condition="'$(PackageIcon)' == '' and '$(PackageIconUrl)' != ''">
68+
<_IconUrlElement Condition="'$(PackageIconUrl)' != ''">
6969
<iconUrl>$(PackageIconUrl)</iconUrl>
7070
</_IconUrlElement>
7171

@@ -101,22 +101,22 @@
101101

102102
<_CommonMetadataElements>
103103
<id>$(PackageId)</id>
104-
$(_TitleElement)
105-
<description>$(PackageDescription)</description>
106104
<version>$(PackageVersion)</version>
105+
$(_TitleElement)
107106
<authors>$(Authors)</authors>
108-
<requireLicenseAcceptance>$(PackageRequireLicenseAcceptance)</requireLicenseAcceptance>
109-
$(_ReadmeElement)
110-
$(_TagsElement)
111107
$(_LicenseElement)
108+
<requireLicenseAcceptance>$(PackageRequireLicenseAcceptance)</requireLicenseAcceptance>
112109
$(_IconElement)
110+
$(_ReadmeElement)
111+
<projectUrl>$(PackageProjectUrl)</projectUrl>
113112
$(_IconUrlElement)
113+
<description>$(PackageDescription)</description>
114114
$(_ReleaseNotesElement)
115-
<projectUrl>$(PackageProjectUrl)</projectUrl>
116115
<copyright>$(Copyright)</copyright>
116+
$(_TagsElement)
117+
<repository type="$(RepositoryType)" url="$(RepositoryUrl)" commit="$(RepositoryCommit)" />
117118
$(_DevelopmentDependencyElement)
118119
$(_ServiceableElement)
119-
<repository type="$(RepositoryType)" url="$(RepositoryUrl)" commit="$(RepositoryCommit)" />
120120
$(_NeutralLanguageElement)
121121
</_CommonMetadataElements>
122122

src/JavaScriptEngineSwitcher.ChakraCore.Native.linux-x64/JavaScriptEngineSwitcher.ChakraCore.Native.linux-x64.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@
1111
<Import Project="../../build/initialize-standard-nuspec-properties.targets" />
1212

1313
<PropertyGroup>
14+
<PackageIconUrl>https://raw.githubusercontent.com/Taritsyn/JavaScriptEngineSwitcher/master/Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconUrl>
15+
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconFullPath>
1416
<Description>This package complements the JavaScriptEngineSwitcher.ChakraCore package and contains the native implementation of ChakraCore for Linux (x64).</Description>
1517
<PackageTags>$(PackageCommonTags);ChakraCore;Linux;x64</PackageTags>
16-
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconFullPath>
1718
<PackageReleaseNotes>ChakraCore was updated to version of January 26, 2023.</PackageReleaseNotes>
1819
</PropertyGroup>
1920

src/JavaScriptEngineSwitcher.ChakraCore.Native.osx-x64/JavaScriptEngineSwitcher.ChakraCore.Native.osx-x64.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@
1111
<Import Project="../../build/initialize-standard-nuspec-properties.targets" />
1212

1313
<PropertyGroup>
14+
<PackageIconUrl>https://raw.githubusercontent.com/Taritsyn/JavaScriptEngineSwitcher/master/Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconUrl>
15+
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconFullPath>
1416
<Description>This package complements the JavaScriptEngineSwitcher.ChakraCore package and contains the native implementation of ChakraCore for OS X (x64).</Description>
1517
<PackageTags>$(PackageCommonTags);ChakraCore;macOS;OSX;x64</PackageTags>
16-
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconFullPath>
1718
<PackageReleaseNotes>ChakraCore was updated to version of January 26, 2023.</PackageReleaseNotes>
1819
</PropertyGroup>
1920

src/JavaScriptEngineSwitcher.ChakraCore.Native.win-arm/JavaScriptEngineSwitcher.ChakraCore.Native.win-arm.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@
1111
<Import Project="../../build/initialize-standard-nuspec-properties.targets" />
1212

1313
<PropertyGroup>
14+
<PackageIconUrl>https://raw.githubusercontent.com/Taritsyn/JavaScriptEngineSwitcher/master/Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconUrl>
15+
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconFullPath>
1416
<Description>This package complements the JavaScriptEngineSwitcher.ChakraCore package and contains the native implementation of ChakraCore for Windows (ARM).</Description>
1517
<PackageTags>$(PackageCommonTags);ChakraCore;Windows;ARM</PackageTags>
16-
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconFullPath>
1718
<PackageReleaseNotes>ChakraCore was updated to version of January 26, 2023.</PackageReleaseNotes>
1819
</PropertyGroup>
1920

src/JavaScriptEngineSwitcher.ChakraCore.Native.win-arm64/JavaScriptEngineSwitcher.ChakraCore.Native.win-arm64.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@
1111
<Import Project="../../build/initialize-standard-nuspec-properties.targets" />
1212

1313
<PropertyGroup>
14+
<PackageIconUrl>https://raw.githubusercontent.com/Taritsyn/JavaScriptEngineSwitcher/master/Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconUrl>
15+
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconFullPath>
1416
<Description>This package complements the JavaScriptEngineSwitcher.ChakraCore package and contains the native implementation of ChakraCore for Windows (ARM64).</Description>
1517
<PackageTags>$(PackageCommonTags);ChakraCore;Windows;ARM64</PackageTags>
16-
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconFullPath>
1718
<PackageReleaseNotes>ChakraCore was updated to version of January 26, 2023.</PackageReleaseNotes>
1819
</PropertyGroup>
1920

src/JavaScriptEngineSwitcher.ChakraCore.Native.win-x64/JavaScriptEngineSwitcher.ChakraCore.Native.win-x64.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@
1111
<Import Project="../../build/initialize-standard-nuspec-properties.targets" />
1212

1313
<PropertyGroup>
14+
<PackageIconUrl>https://raw.githubusercontent.com/Taritsyn/JavaScriptEngineSwitcher/master/Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconUrl>
15+
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconFullPath>
1416
<Description>This package complements the JavaScriptEngineSwitcher.ChakraCore package and contains the native implementation of ChakraCore for Windows (x64).</Description>
1517
<PackageTags>$(PackageCommonTags);ChakraCore;Windows;x64</PackageTags>
16-
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconFullPath>
1718
<PackageReleaseNotes>ChakraCore was updated to version of January 26, 2023.</PackageReleaseNotes>
1819
</PropertyGroup>
1920

src/JavaScriptEngineSwitcher.ChakraCore.Native.win-x86/JavaScriptEngineSwitcher.ChakraCore.Native.win-x86.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@
1111
<Import Project="../../build/initialize-standard-nuspec-properties.targets" />
1212

1313
<PropertyGroup>
14+
<PackageIconUrl>https://raw.githubusercontent.com/Taritsyn/JavaScriptEngineSwitcher/master/Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconUrl>
15+
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconFullPath>
1416
<Description>This package complements the JavaScriptEngineSwitcher.ChakraCore package and contains the native implementation of ChakraCore for Windows (x86).</Description>
1517
<PackageTags>$(PackageCommonTags);ChakraCore;Windows;x86</PackageTags>
16-
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconFullPath>
1718
<PackageReleaseNotes>ChakraCore was updated to version of January 26, 2023.</PackageReleaseNotes>
1819
</PropertyGroup>
1920

src/JavaScriptEngineSwitcher.ChakraCore/JavaScriptEngineSwitcher.ChakraCore.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,10 @@
1919
<Import Project="../../build/nuget-for-dotnet-lib.props" />
2020

2121
<PropertyGroup>
22+
<PackageIconUrl>https://raw.githubusercontent.com/Taritsyn/JavaScriptEngineSwitcher/master/Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconUrl>
23+
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconFullPath>
2224
<Description>JavaScriptEngineSwitcher.ChakraCore contains a `ChakraCoreJsEngine` adapter (wrapper for the ChakraCore).</Description>
2325
<PackageTags>$(PackageCommonTags);ChakraCore</PackageTags>
24-
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconFullPath>
2526
<PackageReleaseNotes>Fixed a error that occurred in the `ReflectionHelpers.IsAllowedProperty` method when running on .NET Core 1.0.</PackageReleaseNotes>
2627
</PropertyGroup>
2728

src/JavaScriptEngineSwitcher.Core/JavaScriptEngineSwitcher.Core.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,10 @@
1818
<Import Project="../../build/nuget-for-dotnet-lib.props" />
1919

2020
<PropertyGroup>
21+
<PackageIconUrl>https://raw.githubusercontent.com/Taritsyn/JavaScriptEngineSwitcher/master/Icons/JavaScriptEngineSwitcher_Core_Logo128x128.png</PackageIconUrl>
22+
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_Core_Logo128x128.png</PackageIconFullPath>
2123
<Description>JavaScript Engine Switcher determines unified interface for access to the basic features of popular JavaScript engines. This library allows you to quickly and easily switch to using of another JavaScript engine.</Description>
2224
<PackageTags>$(PackageCommonTags)</PackageTags>
23-
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_Core_Logo128x128.png</PackageIconFullPath>
2425
<PackageReleaseNotes>In the `JsEngineSwitcher` class was added the `AllowCurrentProperty` property (default `true`).</PackageReleaseNotes>
2526
</PropertyGroup>
2627

src/JavaScriptEngineSwitcher.Extensions.MsDependencyInjection/JavaScriptEngineSwitcher.Extensions.MsDependencyInjection.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,10 @@
1616
<Import Project="../../build/nuget-for-dotnet-lib.props" />
1717

1818
<PropertyGroup>
19+
<PackageIconUrl>https://raw.githubusercontent.com/Taritsyn/JavaScriptEngineSwitcher/master/Icons/JavaScriptEngineSwitcher_Extensions_MsDependencyInjection_Logo128x128.png</PackageIconUrl>
20+
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_Extensions_MsDependencyInjection_Logo128x128.png</PackageIconFullPath>
1921
<Description>JavaScriptEngineSwitcher.Extensions.MsDependencyInjection contains extension methods for adding the JS engine switcher in an `IServiceCollection`.</Description>
2022
<PackageTags>$(PackageCommonTags);DI</PackageTags>
21-
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_Extensions_MsDependencyInjection_Logo128x128.png</PackageIconFullPath>
2223
<PackageReleaseNotes>1. `AddJsEngineSwitcher(Action&lt;IJsEngineSwitcher&gt;)` and `AddJsEngineSwitcher(IJsEngineSwitcher, Action&lt;IJsEngineSwitcher&gt;)` extension methods are replaced by new methods accordingly: `AddJsEngineSwitcher(Action&lt;JsEngineSwitcherOptions&gt;)` and `AddJsEngineSwitcher(IJsEngineSwitcher, Action&lt;JsEngineSwitcherOptions&gt;)`;
2324
2. `AllowCurrentProperty` property of `JsEngineSwitcherOptions` class allows to forbid usage of the `JsEngineSwitcher.Current` property. This feature can be used to fix a error #115 “Concurrency issue when initializing JS engine switcher in startup”. Special thanks to Ville Häkli.</PackageReleaseNotes>
2425
</PropertyGroup>

0 commit comments

Comments
 (0)