In JavaScriptEngineSwitcher.ChakraCore was explicitly specified charset in the JsCreateString, JsCopyString and JsCreatePropertyId methods of NativeMethods class

Author: Taritsyn

src/JavaScriptEngineSwitcher.ChakraCore/JavaScriptEngineSwitcher.ChakraCore.csproj

@@ -24,7 +24,8 @@ This package does not contain the native implementations of ChakraCore. Therefor
 		<PackageIconUrl>https://raw.githubusercontent.com/Taritsyn/JavaScriptEngineSwitcher/master/Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconUrl>
 		<PackageTags>JavaScriptEngineSwitcher;JavaScript;ECMAScript;ChakraCore</PackageTags>
 		<PackageReleaseNotes>1. In the `NativeMethods` class for the `netstandard` and `netcoreapp` targets was changed a calling convention from `StdCall` to `Cdecl`;
-2. Added a `netcoreapp2.1` target.</PackageReleaseNotes>
+2. Charset was explicitly specified in the `JsCreateString`, `JsCopyString` and `JsCreatePropertyId` methods of `NativeMethods` class;
+3. Added a `netcoreapp2.1` target.</PackageReleaseNotes>
 	</PropertyGroup>
 
 	<Import Project="../../build/common.props" />

src/JavaScriptEngineSwitcher.ChakraCore/JsRt/NativeMethods.cs

@@ -334,13 +334,13 @@ internal static extern JsErrorCode JsSetPromiseContinuationCallback(
 
 		#region Hosting
 
-		[DllImport(DllName.Universal, CallingConvention = DefaultCallingConvention)]
+		[DllImport(DllName.Universal, CallingConvention = DefaultCallingConvention, CharSet = CharSet.Ansi)]
 		internal static extern JsErrorCode JsCreateString(string content, UIntPtr length, out JsValue value);
 
 		[DllImport(DllName.Universal, CallingConvention = DefaultCallingConvention, CharSet = CharSet.Unicode)]
 		internal static extern JsErrorCode JsCreateStringUtf16(string content, UIntPtr length, out JsValue value);
 
-		[DllImport(DllName.Universal, CallingConvention = DefaultCallingConvention)]
+		[DllImport(DllName.Universal, CallingConvention = DefaultCallingConvention, CharSet = CharSet.Ansi)]
 		internal static extern JsErrorCode JsCopyString(JsValue value, byte[] buffer, UIntPtr bufferSize,
 			out UIntPtr length);
 
@@ -356,7 +356,7 @@ internal static extern JsErrorCode JsParse(JsValue script, JsSourceContext sourc
 		internal static extern JsErrorCode JsRun(JsValue script, JsSourceContext sourceContext, JsValue sourceUrl,
 			JsParseScriptAttributes parseAttributes, out JsValue result);
 
-		[DllImport(DllName.Universal, CallingConvention = DefaultCallingConvention)]
+		[DllImport(DllName.Universal, CallingConvention = DefaultCallingConvention, CharSet = CharSet.Ansi)]
 		internal static extern JsErrorCode JsCreatePropertyId(string name, UIntPtr length,
 			out JsPropertyId propertyId);
 

src/JavaScriptEngineSwitcher.ChakraCore/readme.txt

@@ -32,7 +32,9 @@
    =============
    1. In the `NativeMethods` class for the `netstandard` and `netcoreapp` targets
       was changed a calling convention from `StdCall` to `Cdecl`;
-   2. Added a `netcoreapp2.1` target.
+   2. Charset was explicitly specified in the `JsCreateString`, `JsCopyString` and
+      `JsCreatePropertyId` methods of `NativeMethods` class;
+   3. Added a `netcoreapp2.1` target.
 
    =============
    DOCUMENTATION