Skip to content

Commit 637c37b

Browse files
committed
Fixed a minor flaws
1 parent ad14dbb commit 637c37b

File tree

14 files changed

+22
-30
lines changed

14 files changed

+22
-30
lines changed

src/JavaScriptEngineSwitcher.ChakraCore/JavaScriptEngineSwitcher.ChakraCore.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ This package does not contain the native implementations of ChakraCore. Therefor
9191
</Content>
9292
</ItemGroup>
9393

94-
<Target Name="СonvertResxToCs" BeforeTargets="BeforeCompile">
94+
<Target Name="ConvertResxToCs" BeforeTargets="BeforeCompile">
9595
<ResxToCsTask InputDirectory="./Resources/" Namespace="$(RootNamespace).Resources" InternalAccessModifier="true" />
9696
</Target>
9797

src/JavaScriptEngineSwitcher.ChakraCore/JsRt/Embedding/EmbeddedItem.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ internal abstract class EmbeddedItem : IDisposable
3333
/// <summary>
3434
/// Flag indicating whether this object is disposed
3535
/// </summary>
36-
private readonly InterlockedStatedFlag _disposedFlag = new InterlockedStatedFlag();
36+
private InterlockedStatedFlag _disposedFlag = new InterlockedStatedFlag();
3737

3838
/// <summary>
3939
/// Gets a host type

src/JavaScriptEngineSwitcher.ChakraCore/JsRt/TypeMapper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ internal sealed class TypeMapper : IDisposable
7474
/// <summary>
7575
/// Flag indicating whether this object is disposed
7676
/// </summary>
77-
private readonly InterlockedStatedFlag _disposedFlag = new InterlockedStatedFlag();
77+
private InterlockedStatedFlag _disposedFlag = new InterlockedStatedFlag();
7878

7979

8080
/// <summary>

src/JavaScriptEngineSwitcher.Core/Helpers/JsErrorHelpers.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,6 @@ public static class JsErrorHelpers
3939
@")" +
4040
@"(?: -> (?<sourceFragment>[^\n\r]+))?$");
4141

42-
/// <summary>
43-
/// Regular expression for working with a line break
44-
/// </summary>
45-
private static readonly Regex _lineBreakRegex = new Regex("\r\n|\n|\r");
46-
4742
/// <summary>
4843
/// Parses a string representation of the script error location to produce an array of
4944
/// <see cref="ErrorLocationItem"/> instances

src/JavaScriptEngineSwitcher.Core/JavaScriptEngineSwitcher.Core.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
</Content>
4747
</ItemGroup>
4848

49-
<Target Name="СonvertResxToCs" BeforeTargets="BeforeCompile">
49+
<Target Name="ConvertResxToCs" BeforeTargets="BeforeCompile">
5050
<ResxToCsTask InputDirectory="./Resources/" Namespace="$(RootNamespace).Resources" />
5151
</Target>
5252

src/JavaScriptEngineSwitcher.Core/Resources/Strings.Designer.cs

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/JavaScriptEngineSwitcher.Core/Resources/Strings.resx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -223,19 +223,19 @@
223223
<value>Cannot convert a pre-compiled script to internal type `{0}`.</value>
224224
</data>
225225
<data name="Usage_CannotExecuteEmptyFile" xml:space="preserve">
226-
<value>Сannot execute a '{0}' file, because it is empty.</value>
226+
<value>Cannot execute a '{0}' file, because it is empty.</value>
227227
</data>
228228
<data name="Usage_CannotExecuteEmptyResource" xml:space="preserve">
229-
<value>Сannot execute a '{0}' resource, because it is empty.</value>
229+
<value>Cannot execute a '{0}' resource, because it is empty.</value>
230230
</data>
231231
<data name="Usage_CannotExecutePrecompiledScriptForAnotherJsEngine" xml:space="preserve">
232-
<value>Сannot execute a pre-compiled script, because it was created for another JS engine with name `{0}`.</value>
232+
<value>Cannot execute a pre-compiled script, because it was created for another JS engine with name `{0}`.</value>
233233
</data>
234234
<data name="Usage_CannotPrecompileEmptyFile" xml:space="preserve">
235-
<value>Сannot pre-compile a '{0}' file, because it is empty.</value>
235+
<value>Cannot pre-compile a '{0}' file, because it is empty.</value>
236236
</data>
237237
<data name="Usage_CannotPrecompileEmptyResource" xml:space="preserve">
238-
<value>Сannot pre-compile a '{0}' resource, because it is empty.</value>
238+
<value>Cannot pre-compile a '{0}' resource, because it is empty.</value>
239239
</data>
240240
<data name="Usage_EmbeddedHostObjectTypeNotSupported" xml:space="preserve">
241241
<value>The embedded host object '{0}' has a type `{1}`, which is not supported.</value>

src/JavaScriptEngineSwitcher.Msie/JavaScriptEngineSwitcher.Msie.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
</Content>
4545
</ItemGroup>
4646

47-
<Target Name="СonvertResxToCs" BeforeTargets="BeforeCompile">
47+
<Target Name="ConvertResxToCs" BeforeTargets="BeforeCompile">
4848
<ResxToCsTask InputDirectory="./Resources/" Namespace="$(RootNamespace).Resources" InternalAccessModifier="true" />
4949
</Target>
5050

src/JavaScriptEngineSwitcher.Node/NodeJsEngine.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -588,7 +588,7 @@ public override void Dispose()
588588
{
589589
if (_disposedFlag.Set())
590590
{
591-
InvokeEngineHelper("removeСontext", new[] { _engineId });
591+
InvokeEngineHelper("removeContext", new[] { _engineId });
592592
_jsService = null;
593593
}
594594
}

src/JavaScriptEngineSwitcher.Node/Resources/engine-helpers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ module.exports = {
3636
callback(null);
3737
},
3838

39-
removeСontext: (callback, engineId) => {
39+
removeContext: (callback, engineId) => {
4040
contexts.delete(engineId);
4141
callback(null);
4242
},

0 commit comments

Comments
 (0)