In JavaScriptEngineSwitcher.V8 in configuration settings of the V8 JS engine was changed types of MaxHeapSize and MaxStackUsage properties from ulong to UIntPtr

Author: Taritsyn

NuGet/JavaScriptEngineSwitcher.V8/JavaScriptEngineSwitcher.V8.nuspec

@@ -17,9 +17,7 @@ This package does not contain the native ClearScript and V8 assemblies. Therefor
  * JavaScriptEngineSwitcher.V8.Native.win-x86
  * JavaScriptEngineSwitcher.V8.Native.win-x64</description>
 		<summary>JavaScriptEngineSwitcher.V8 contains adapter `V8JsEngine` (wrapper for the Microsoft ClearScript.V8 version 5.5.0).</summary>
-		<releaseNotes>1. Microsoft ClearScript.V8 was updated to version 5.5.0 (support of V8 version 6.2.414.40);
-2. Now requires .NET Framework 4.5 or greater;
-3. In configuration settings of the V8 JS engine became obsolete the `MaxExecutableSize` property and was added 4 new properties: `EnableRemoteDebugging` (default `false`), `HeapSizeSampleInterval` (default `TimeSpan.Zero`), `MaxHeapSize` (default `0`) and `MaxStackUsage` (default `0`).</releaseNotes>
+		<releaseNotes>In configuration settings of the V8 JS engine was changed types of `MaxHeapSize` and `MaxStackUsage` properties from `ulong` to `UIntPtr`.</releaseNotes>
 		<copyright>Copyright (c) 2013-2017 Andrey Taritsyn - http://www.taritsyn.ru</copyright>
 		<language>en-US</language>
 		<tags>JavaScriptEngineSwitcher JavaScript ECMAScript V8 ClearScript</tags>

NuGet/JavaScriptEngineSwitcher.V8/readme.txt

@@ -25,14 +25,8 @@
    =============
    RELEASE NOTES
    =============
-   1. Microsoft ClearScript.V8 was updated to version 5.5.0 (support of V8 version
-      6.2.414.40);
-   2. Now requires .NET Framework 4.5 or greater;
-   3. In configuration settings of the V8 JS engine became obsolete the
-      `MaxExecutableSize` property and was added 4 new properties:
-      `EnableRemoteDebugging` (default `false`), `HeapSizeSampleInterval` (default
-      `TimeSpan.Zero`), `MaxHeapSize` (default `0`) and `MaxStackUsage` (default
-      `0`).
+   In configuration settings of the V8 JS engine was changed types of `MaxHeapSize`
+   and `MaxStackUsage` properties from `ulong` to `UIntPtr`.
 
    =============
    DOCUMENTATION

src/JavaScriptEngineSwitcher.V8/V8JsEngine.cs

@@ -97,9 +97,9 @@ public V8JsEngine(V8Settings settings)
 			try
 			{
 				_jsEngine = new V8ScriptEngine(constraints, flags, debugPort);
-				_jsEngine.MaxRuntimeHeapSize = new UIntPtr(v8Settings.MaxHeapSize);
+				_jsEngine.MaxRuntimeHeapSize = v8Settings.MaxHeapSize;
 				_jsEngine.RuntimeHeapSizeSampleInterval = v8Settings.HeapSizeSampleInterval;
-				_jsEngine.MaxRuntimeStackUsage = new UIntPtr(v8Settings.MaxStackUsage);
+				_jsEngine.MaxRuntimeStackUsage = v8Settings.MaxStackUsage;
 			}
 			catch (Exception e)
 			{

src/JavaScriptEngineSwitcher.V8/V8Settings.cs

@@ -92,7 +92,7 @@ public int MaxExecutableSize
 		/// an exception.
 		/// </para>
 		/// </remarks>
-		public ulong MaxHeapSize
+		public UIntPtr MaxHeapSize
 		{
 			get;
 			set;
@@ -131,7 +131,7 @@ public int MaxOldSpaceSize
 		/// Monitoring is resumed when control returns to the runtime.
 		/// </para>
 		/// </remarks>
-		public ulong MaxStackUsage
+		public UIntPtr MaxStackUsage
 		{
 			get;
 			set;
@@ -148,10 +148,10 @@ public V8Settings()
 			DebugPort = 9222;
 			DisableGlobalMembers = false;
 			HeapSizeSampleInterval = TimeSpan.Zero;
-			MaxHeapSize = 0;
+			MaxHeapSize = UIntPtr.Zero;
 			MaxNewSpaceSize = 0;
 			MaxOldSpaceSize = 0;
-			MaxStackUsage = 0;
+			MaxStackUsage = UIntPtr.Zero;
 		}
 	}
 }