Skip to content

Commit c45ca0a

Browse files
committed
In JavaScriptEngineSwitcher.ChakraCore fixed a error that occurred in the ReflectionHelpers.IsAllowedProperty method when running on .NET Core 1.0
1 parent b33786c commit c45ca0a

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

src/JavaScriptEngineSwitcher.ChakraCore/Helpers/ReflectionHelpers.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,15 @@ private MemberComparer()
262262

263263
public override bool Equals(T x, T y)
264264
{
265+
if (x == null && y == null)
266+
{
267+
return true;
268+
}
269+
else if (x == null || y == null)
270+
{
271+
return false;
272+
}
273+
265274
return x.Module == y.Module
266275
#if !NETSTANDARD1_3
267276
&& x.MetadataToken == y.MetadataToken

src/JavaScriptEngineSwitcher.ChakraCore/JavaScriptEngineSwitcher.ChakraCore.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ This package does not contain the native implementations of ChakraCore. Therefor
3131
* JavaScriptEngineSwitcher.ChakraCore.Native.osx-x64</Description>
3232
<PackageTags>$(PackageCommonTags);ChakraCore</PackageTags>
3333
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconFullPath>
34-
<PackageReleaseNotes>1. ChakraCore was updated to version of January 26, 2023;
35-
2. In configuration settings of the ChakraCore JS engine was added one new property - `AllowReflection` (default `false`).</PackageReleaseNotes>
34+
<PackageReleaseNotes>Fixed a error that occurred in the `ReflectionHelpers.IsAllowedProperty` method when running on .NET Core 1.0.</PackageReleaseNotes>
3635
</PropertyGroup>
3736

3837
<ItemGroup>

src/JavaScriptEngineSwitcher.ChakraCore/readme.txt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,8 @@
3131
=============
3232
RELEASE NOTES
3333
=============
34-
1. ChakraCore was updated to version of January 26, 2023;
35-
2. In configuration settings of the ChakraCore JS engine was added one new
36-
property - `AllowReflection` (default `false`).
34+
Fixed a error that occurred in the `ReflectionHelpers.IsAllowedProperty` method
35+
when running on .NET Core 1.0.
3736

3837
=============
3938
DOCUMENTATION

0 commit comments

Comments
 (0)