Skip to content

Commit cbe0574

Browse files
committed
Fixed a minor errors
1 parent ed1f081 commit cbe0574

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

src/JavaScriptEngineSwitcher.Core/IJsEngine.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ bool SupportsGarbageCollection
8181
/// </summary>
8282
/// <param name="path">Path to the JS file</param>
8383
/// <param name="encoding">Text encoding</param>
84+
/// <returns>A pre-compiled script that can be executed by different instances of JS engine</returns>
8485
/// <exception cref="ObjectDisposedException"/>
8586
/// <exception cref="ArgumentNullException"/>
8687
/// <exception cref="ArgumentException"/>
@@ -96,6 +97,7 @@ bool SupportsGarbageCollection
9697
/// <param name="resourceName">The case-sensitive resource name without the namespace of the specified type</param>
9798
/// <param name="type">The type, that determines the assembly and whose namespace is used to scope
9899
/// the resource name</param>
100+
/// <returns>A pre-compiled script that can be executed by different instances of JS engine</returns>
99101
/// <exception cref="ObjectDisposedException"/>
100102
/// <exception cref="ArgumentNullException"/>
101103
/// <exception cref="ArgumentException"/>
@@ -110,6 +112,7 @@ bool SupportsGarbageCollection
110112
/// </summary>
111113
/// <param name="resourceName">The case-sensitive resource name</param>
112114
/// <param name="assembly">The assembly, which contains the embedded resource</param>
115+
/// <returns>A pre-compiled script that can be executed by different instances of JS engine</returns>
113116
/// <exception cref="ObjectDisposedException"/>
114117
/// <exception cref="ArgumentNullException"/>
115118
/// <exception cref="ArgumentException"/>
@@ -215,6 +218,8 @@ bool SupportsGarbageCollection
215218
/// <summary>
216219
/// Executes a pre-compiled script
217220
/// </summary>
221+
/// <param name="precompiledScript">A pre-compiled script that can be executed by different
222+
/// instances of JS engine</param>
218223
/// <exception cref="ObjectDisposedException"/>
219224
/// <exception cref="ArgumentNullException"/>
220225
/// <exception cref="ArgumentException"/>

test/JavaScriptEngineSwitcher.Tests/PrecompilationTestsBase.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ public virtual void ExecutionOfPrecompiledResourceByNameAndTypeIsCorrect()
208208
supportsScriptPrecompilation = jsEngine.SupportsScriptPrecompilation;
209209
if (supportsScriptPrecompilation)
210210
{
211-
precompiledResource = jsEngine.PrecompileResource(resourceName, typeof(CommonTestsBase));
211+
precompiledResource = jsEngine.PrecompileResource(resourceName, typeof(PrecompilationTestsBase));
212212

213213
jsEngine.Execute(precompiledResource);
214214
output0 = jsEngine.CallFunction<string>(functionName, input0);
@@ -280,7 +280,7 @@ public virtual void ExecutionOfPrecompiledResourceByNameAndAssemblyIsCorrect()
280280
if (supportsScriptPrecompilation)
281281
{
282282
precompiledResource = jsEngine.PrecompileResource(resourceName,
283-
typeof(CommonTestsBase).GetTypeInfo().Assembly);
283+
typeof(PrecompilationTestsBase).GetTypeInfo().Assembly);
284284

285285
jsEngine.Execute(precompiledResource);
286286
output0 = jsEngine.CallFunction<string>(functionName, input0);

0 commit comments

Comments
 (0)