Fixed a error #22 “Make Exception serializable”

Author: Taritsyn

src/JavaScriptEngineSwitcher.ChakraCore/ChakraCoreJsEngine.cs

@@ -903,8 +903,7 @@ private static JsRuntimeException ConvertJsExceptionToJsRuntimeException(
 				Category = category,
 				LineNumber = lineNumber,
 				ColumnNumber = columnNumber,
-				SourceFragment = sourceFragment,
-				HelpLink = jsException.HelpLink
+				SourceFragment = sourceFragment
 			};
 
 			return jsEngineException;

src/JavaScriptEngineSwitcher.ChakraCore/JsRt/JsEngineException.cs

@@ -1,25 +1,45 @@
+#if !NETSTANDARD1_3
+using System;
+using System.Runtime.Serialization;
+#endif
+
 namespace JavaScriptEngineSwitcher.ChakraCore.JsRt
 {
 	/// <summary>
 	/// The exception that occurred in the workings of the JavaScript engine itself
 	/// </summary>
+#if !NETSTANDARD1_3
+	[Serializable]
+#endif
 	internal sealed class JsEngineException : JsException
 	{
 		/// <summary>
 		/// Initializes a new instance of the <see cref="JsEngineException"/> class
 		/// </summary>
-		/// <param name="code">The error code returned</param>
-		public JsEngineException(JsErrorCode code)
-			: this(code, "A fatal exception has occurred in a JavaScript runtime")
+		/// <param name="errorCode">The error code returned</param>
+		public JsEngineException(JsErrorCode errorCode)
+			: this(errorCode, "A fatal exception has occurred in a JavaScript runtime")
 		{ }
 
 		/// <summary>
 		/// Initializes a new instance of the <see cref="JsEngineException"/> class
+		/// with a specified error message
 		/// </summary>
-		/// <param name="code">The error code returned</param>
+		/// <param name="errorCode">The error code returned</param>
 		/// <param name="message">The error message</param>
-		public JsEngineException(JsErrorCode code, string message)
-			: base(code, message)
+		public JsEngineException(JsErrorCode errorCode, string message)
+			: base(errorCode, message)
+		{ }
+#if !NETSTANDARD1_3
+
+		/// <summary>
+		/// Initializes a new instance of the <see cref="JsEngineException"/> class with serialized data
+		/// </summary>
+		/// <param name="info">The object that holds the serialized data</param>
+		/// <param name="context">The contextual information about the source or destination</param>
+		private JsEngineException(SerializationInfo info, StreamingContext context)
+			: base(info, context)
 		{ }
+#endif
 	}
 }

src/JavaScriptEngineSwitcher.ChakraCore/JsRt/JsException.cs

@@ -1,57 +1,89 @@
 using System;
+#if !NETSTANDARD1_3
+using System.Runtime.Serialization;
+using System.Security.Permissions;
+#endif
 
 namespace JavaScriptEngineSwitcher.ChakraCore.JsRt
 {
 	/// <summary>
 	/// The exception returned from the Chakra engine
 	/// </summary>
+#if !NETSTANDARD1_3
+	[Serializable]
+#endif
 	internal class JsException : Exception
 	{
 		/// <summary>
 		/// The error code
 		/// </summary>
-		private readonly JsErrorCode _code;
+		private readonly JsErrorCode _errorCode;
 
 		/// <summary>
 		/// Gets a error code
 		/// </summary>
 		public JsErrorCode ErrorCode
 		{
-			get { return _code; }
+			get { return _errorCode; }
 		}
 
 
 		/// <summary>
 		/// Initializes a new instance of the <see cref="JsException"/> class
 		/// </summary>
-		/// <param name="code">The error code returned</param>
-		public JsException(JsErrorCode code)
-			: this(code, "A fatal exception has occurred in a JavaScript runtime")
+		/// <param name="errorCode">The error code returned</param>
+		public JsException(JsErrorCode errorCode)
+			: this(errorCode, "A fatal exception has occurred in a JavaScript runtime")
 		{ }
 
 		/// <summary>
 		/// Initializes a new instance of the <see cref="JsException"/> class
+		/// with a specified error message
 		/// </summary>
-		/// <param name="code">The error code returned</param>
+		/// <param name="errorCode">The error code returned</param>
 		/// <param name="message">The error message</param>
-		public JsException(JsErrorCode code, string message)
+		public JsException(JsErrorCode errorCode, string message)
 			: base(message)
 		{
-			_code = code;
+			_errorCode = errorCode;
 		}
+#if !NETSTANDARD1_3
 
 		/// <summary>
-		/// Initializes a new instance of the <see cref="JsException"/> class
+		/// Initializes a new instance of the <see cref="JsException"/> class with serialized data
 		/// </summary>
-		/// <param name="message">The error message</param>
-		/// <param name="innerException">The exception that is the cause of the current exception</param>
-		protected JsException(string message, Exception innerException)
-			: base(message, innerException)
+		/// <param name="info">The object that holds the serialized data</param>
+		/// <param name="context">The contextual information about the source or destination</param>
+		protected JsException(SerializationInfo info, StreamingContext context)
+			: base(info, context)
 		{
-			if (message != null)
+			if (info != null)
 			{
-				_code = (JsErrorCode) HResult;
+				_errorCode = (JsErrorCode)info.GetUInt32("ErrorCode");
 			}
 		}
+
+
+		#region Exception overrides
+
+		/// <summary>
+		/// Populates a <see cref="SerializationInfo"/> with the data needed to serialize the target object
+		/// </summary>
+		/// <param name="info">The <see cref="SerializationInfo"/> to populate with data</param>
+		/// <param name="context">The destination (see <see cref="StreamingContext"/>) for this serialization</param>
+		[SecurityPermission(SecurityAction.Demand, SerializationFormatter = true)]
+		public override void GetObjectData(SerializationInfo info, StreamingContext context)
+		{
+			if (info == null)
+			{
+				throw new ArgumentNullException("info");
+			}
+
+			base.GetObjectData(info, context);
+			info.AddValue("ErrorCode", (uint)_errorCode);
+		}
+
+		#endregion
+#endif
 	}
 }

src/JavaScriptEngineSwitcher.ChakraCore/JsRt/JsFatalException.cs

@@ -1,25 +1,45 @@
-namespace JavaScriptEngineSwitcher.ChakraCore.JsRt
+#if !NETSTANDARD1_3
+using System;
+using System.Runtime.Serialization;
+#endif
+
+namespace JavaScriptEngineSwitcher.ChakraCore.JsRt
 {
 	/// <summary>
 	/// The fatal exception occurred
 	/// </summary>
+#if !NETSTANDARD1_3
+	[Serializable]
+#endif
 	internal sealed class JsFatalException : JsException
 	{
 		/// <summary>
 		/// Initializes a new instance of the <see cref="JsFatalException"/> class
 		/// </summary>
-		/// <param name="code">The error code returned</param>
-		public JsFatalException(JsErrorCode code)
-			: this(code, "A fatal exception has occurred in a JavaScript runtime")
+		/// <param name="errorCode">The error code returned</param>
+		public JsFatalException(JsErrorCode errorCode)
+			: this(errorCode, "A fatal exception has occurred in a JavaScript runtime")
 		{ }
 
 		/// <summary>
 		/// Initializes a new instance of the <see cref="JsFatalException"/> class
+		/// with a specified error message
 		/// </summary>
-		/// <param name="code">The error code returned</param>
+		/// <param name="errorCode">The error code returned</param>
 		/// <param name="message">The error message</param>
-		public JsFatalException(JsErrorCode code, string message)
-			: base(code, message)
+		public JsFatalException(JsErrorCode errorCode, string message)
+			: base(errorCode, message)
+		{ }
+#if !NETSTANDARD1_3
+
+		/// <summary>
+		/// Initializes a new instance of the <see cref="JsFatalException"/> class with serialized data
+		/// </summary>
+		/// <param name="info">The object that holds the serialized data</param>
+		/// <param name="context">The contextual information about the source or destination</param>
+		private JsFatalException(SerializationInfo info, StreamingContext context)
+			: base(info, context)
 		{ }
+#endif
 	}
 }

src/JavaScriptEngineSwitcher.ChakraCore/JsRt/JsScriptException.cs

@@ -1,57 +1,66 @@
+#if !NETSTANDARD1_3
 using System;
+using System.Runtime.Serialization;
+#endif
 
 namespace JavaScriptEngineSwitcher.ChakraCore.JsRt
 {
 	/// <summary>
 	/// The script exception
 	/// </summary>
+#if !NETSTANDARD1_3
+	[Serializable]
+#endif
 	internal sealed class JsScriptException : JsException
 	{
 		/// <summary>
 		/// The error
 		/// </summary>
+#if !NETSTANDARD1_3
+		[NonSerialized]
+#endif
 		private readonly JsValue _error;
 
 		/// <summary>
 		/// Gets a JavaScript object representing the script error
 		/// </summary>
 		public JsValue Error
 		{
-			get
-			{
-				return _error;
-			}
+			get { return _error; }
 		}
 
 
 		/// <summary>
 		/// Initializes a new instance of the <see cref="JsScriptException"/> class
 		/// </summary>
-		/// <param name="code">The error code returned</param>
+		/// <param name="errorCode">The error code returned</param>
 		/// <param name="error">The JavaScript error object</param>
-		public JsScriptException(JsErrorCode code, JsValue error)
-			: this(code, error, "JavaScript Exception")
+		public JsScriptException(JsErrorCode errorCode, JsValue error)
+			: this(errorCode, error, "JavaScript Exception")
 		{ }
 
 		/// <summary>
 		/// Initializes a new instance of the <see cref="JsScriptException"/> class
+		/// with a specified error message
 		/// </summary>
-		/// <param name="code">The error code returned</param>
+		/// <param name="errorCode">The error code returned</param>
 		/// <param name="error">The JavaScript error object</param>
 		/// <param name="message">The error message</param>
-		public JsScriptException(JsErrorCode code, JsValue error, string message)
-			: base(code, message)
+		public JsScriptException(JsErrorCode errorCode, JsValue error, string message)
+			: base(errorCode, message)
 		{
 			_error = error;
 		}
+#if !NETSTANDARD1_3
 
 		/// <summary>
-		/// Initializes a new instance of the <see cref="JsScriptException"/> class
+		/// Initializes a new instance of the <see cref="JsScriptException"/> class with serialized data
 		/// </summary>
-		/// <param name="message">The error message</param>
-		/// <param name="innerException">The exception that is the cause of the current exception</param>
-		private JsScriptException(string message, Exception innerException)
-			: base(message, innerException)
+		/// <param name="info">The object that holds the serialized data</param>
+		/// <param name="context">The contextual information about the source or destination</param>
+		private JsScriptException(SerializationInfo info, StreamingContext context)
+			: base(info, context)
 		{ }
+#endif
 	}
 }

src/JavaScriptEngineSwitcher.ChakraCore/JsRt/JsUsageException.cs

@@ -1,25 +1,45 @@
-namespace JavaScriptEngineSwitcher.ChakraCore.JsRt
+#if !NETSTANDARD1_3
+using System;
+using System.Runtime.Serialization;
+#endif
+
+namespace JavaScriptEngineSwitcher.ChakraCore.JsRt
 {
 	/// <summary>
 	/// The API usage exception occurred
 	/// </summary>
+#if !NETSTANDARD1_3
+	[Serializable]
+#endif
 	internal sealed class JsUsageException : JsException
 	{
 		/// <summary>
 		/// Initializes a new instance of the <see cref="JsUsageException"/> class
 		/// </summary>
-		/// <param name="code">The error code returned</param>
-		public JsUsageException(JsErrorCode code)
-			: this(code, "A fatal exception has occurred in a JavaScript runtime")
+		/// <param name="errorCode">The error code returned</param>
+		public JsUsageException(JsErrorCode errorCode)
+			: this(errorCode, "A fatal exception has occurred in a JavaScript runtime")
 		{ }
 
 		/// <summary>
 		/// Initializes a new instance of the <see cref="JsUsageException"/> class
+		/// with a specified error message
 		/// </summary>
-		/// <param name="code">The error code returned</param>
+		/// <param name="errorCode">The error code returned</param>
 		/// <param name="message">The error message</param>
-		public JsUsageException(JsErrorCode code, string message)
-			: base(code, message)
+		public JsUsageException(JsErrorCode errorCode, string message)
+			: base(errorCode, message)
+		{ }
+#if !NETSTANDARD1_3
+
+		/// <summary>
+		/// Initializes a new instance of the <see cref="JsUsageException"/> class with serialized data
+		/// </summary>
+		/// <param name="info">The object that holds the serialized data</param>
+		/// <param name="context">The contextual information about the source or destination</param>
+		private JsUsageException(SerializationInfo info, StreamingContext context)
+			: base(info, context)
 		{ }
+#endif
 	}
 }

src/JavaScriptEngineSwitcher.Core/EmptyValueException.cs

@@ -1,10 +1,16 @@
 using System;
+#if !NETSTANDARD1_3
+using System.Runtime.Serialization;
+#endif
 
 namespace JavaScriptEngineSwitcher.Core
 {
 	/// <summary>
 	/// The exception that is thrown when a specified value is null or empty
 	/// </summary>
+#if !NETSTANDARD1_3
+	[Serializable]
+#endif
 	public sealed class EmptyValueException : Exception
 	{
 		/// <summary>
@@ -25,5 +31,16 @@ public EmptyValueException(string message)
 		public EmptyValueException(string message, Exception innerException)
 			: base(message, innerException)
 		{ }
+#if !NETSTANDARD1_3
+
+		/// <summary>
+		/// Initializes a new instance of the <see cref="EmptyValueException"/> class with serialized data
+		/// </summary>
+		/// <param name="info">The object that holds the serialized data</param>
+		/// <param name="context">The contextual information about the source or destination</param>
+		private EmptyValueException(SerializationInfo info, StreamingContext context)
+			: base(info, context)
+		{ }
+#endif
 	}
 }