Fixed a error due to which the global object to become read-only after embedding of the host objects and types

Author: Taritsyn

src/MsieJavaScriptEngine/ActiveScript/ActiveScriptJsEngineBase.cs

@@ -535,7 +535,7 @@ private void InnerEmbedHostItem(string itemName, object value)
 
 			try
 			{
-				_activeScriptWrapper.AddNamedItem(itemName, ScriptItemFlags.IsVisible | ScriptItemFlags.GlobalMembers);
+				_activeScriptWrapper.AddNamedItem(itemName, ScriptItemFlags.IsVisible);
 			}
 			catch
 			{

src/MsieJavaScriptEngine/MsieJavaScriptEngine.csproj

@@ -25,7 +25,7 @@
     <IncludeSymbols>true</IncludeSymbols>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <PackageTags>JavaScript;ECMAScript;MSIE;IE;Edge;Chakra</PackageTags>
-    <PackageReleaseNotes>In JsRT modes improved a performance of .NET methods projection.</PackageReleaseNotes>
+    <PackageReleaseNotes>Fixed a error due to which the global object to become read-only after embedding of the host objects and types.</PackageReleaseNotes>
     <NeutralLanguage>en-US</NeutralLanguage>
     <PackageOutputPath>../../nuget</PackageOutputPath>
     <GeneratePackageOnBuild Condition=" '$(Configuration)' == 'Release' ">true</GeneratePackageOnBuild>

src/MsieJavaScriptEngine/readme.txt

@@ -21,7 +21,8 @@
    =============
    RELEASE NOTES
    =============
-   In JsRT modes improved a performance of .NET methods projection.
+   Fixed a error due to which the global object to become read-only after embedding
+   of the host objects and types.
 
    ============
    PROJECT SITE

test/MsieJavaScriptEngine.Test.Common/Interop/SomeClass.cs

@@ -0,0 +1,10 @@
+namespace MsieJavaScriptEngine.Test.Common.Interop
+{
+	public class SomeClass
+	{
+		public int SomeProperty { get; set; } = 123;
+		public string SomeOtherProperty { get; set; } = "abc";
+
+		public static SomeClass Instance { get; } = new SomeClass();
+	}
+}

test/MsieJavaScriptEngine.Test.Common/InteropTestsBase.cs

@@ -877,6 +877,41 @@ public virtual void RemovingOfEmbeddedInstanceOfCustomReferenceType()
 
 		#endregion
 
+		#region Special cases
+
+		[Test]
+		public virtual void EmbeddingOfInstanceOfCustomReferenceTypeAndModificationOfGlobalObject()
+		{
+			// Arrange
+			var someObj = new SomeClass();
+
+			const string modifyingCode = @"(function () {
+	'use strict';
+
+	var global = typeof self != 'undefined' && self.Math == Math ?
+		self : Function('return this')();
+
+	global['foo'] = 'bar';
+})();";
+			const string variableName = "foo";
+			const string targetOutput = "bar";
+
+			// Act
+			string output;
+
+			using (var jsEngine = CreateJsEngine())
+			{
+				jsEngine.EmbedHostObject("someObj", someObj);
+				jsEngine.Execute(modifyingCode);
+				output = jsEngine.GetVariableValue<string>(variableName);
+			}
+
+			// Assert
+			Assert.AreEqual(targetOutput, output);
+		}
+
+		#endregion
+
 		#endregion
 
 
@@ -1443,6 +1478,41 @@ public virtual void RemovingOfEmbeddedCustomReferenceType()
 
 		#endregion
 
+		#region Special cases
+
+		[Test]
+		public virtual void EmbeddingOfCustomReferenceTypeAndModificationOfGlobalObject()
+		{
+			// Arrange
+			var someType = typeof(SomeClass);
+
+			const string modifyingCode = @"(function () {
+	'use strict';
+
+	var global = typeof self != 'undefined' && self.Math == Math ?
+		self : Function('return this')();
+
+	global.foo = 'baz';
+})();";
+			const string variableName = "foo";
+			const string targetOutput = "baz";
+
+			// Act
+			string output;
+
+			using (var jsEngine = CreateJsEngine())
+			{
+				jsEngine.EmbedHostType("SomeType", someType);
+				jsEngine.Execute(modifyingCode);
+				output = jsEngine.GetVariableValue<string>(variableName);
+			}
+
+			// Assert
+			Assert.AreEqual(targetOutput, output);
+		}
+
+		#endregion
+
 		#endregion
 	}
 }