In JavaScript engine settings was added one new property - MaxStackSize (default 492 or 984 KB)

Author: Taritsyn

src/MsieJavaScriptEngine/ActiveScript/ActiveScriptJsEngineBase.cs

@@ -49,11 +49,6 @@ internal abstract partial class ActiveScriptJsEngineBase : InnerJsEngineBase
 		/// </summary>
 		private ActiveScriptException _lastException;
 
-		/// <summary>
-		/// Instance of script dispatcher
-		/// </summary>
-		private static readonly ScriptDispatcher _dispatcher = new ScriptDispatcher();
-
 		/// <summary>
 		/// Instance of process debug manager wrapper
 		/// </summary>
@@ -104,6 +99,16 @@ internal abstract partial class ActiveScriptJsEngineBase : InnerJsEngineBase
 		/// </summary>
 		protected bool _interruptRequested;
 
+		/// <summary>
+		/// Instance of script dispatcher
+		/// </summary>
+		private static ScriptDispatcher _dispatcher;
+
+		/// <summary>
+		/// Synchronizer of script dispatcher initialization
+		/// </summary>
+		private static readonly object _dispatcherSynchronizer = new object();
+
 
 		/// <summary>
 		/// Constructs an instance of the Active Script engine
@@ -117,6 +122,8 @@ protected ActiveScriptJsEngineBase(JsEngineSettings settings, string clsid,
 			ScriptLanguageVersion languageVersion, string lowerIeVersion, string errorCategoryNamePrefix)
 			: base(settings)
 		{
+			InitScriptDispatcher(_settings.MaxStackSize);
+
 			_lowerIeVersion = lowerIeVersion;
 			_errorCategoryNamePrefix = errorCategoryNamePrefix;
 
@@ -173,6 +180,29 @@ protected ActiveScriptJsEngineBase(JsEngineSettings settings, string clsid,
 		}
 
 
+		/// <summary>
+		/// Initializes a script dispatcher
+		/// </summary>
+		/// <param name="maxStackSize">The maximum stack size, in bytes, to be used by the thread,
+		/// or 0 to use the default maximum stack size specified in the header for the executable.</param>
+		private static void InitScriptDispatcher(int maxStackSize)
+		{
+			if (_dispatcher != null)
+			{
+				return;
+			}
+
+			lock (_dispatcherSynchronizer)
+			{
+				if (_dispatcher != null)
+				{
+					return;
+				}
+
+				_dispatcher = new ScriptDispatcher(maxStackSize);
+			}
+		}
+
 		/// <summary>
 		/// Checks a support of the JS engine on the machine
 		/// </summary>

src/MsieJavaScriptEngine/JsEngineSettings.cs

@@ -1,10 +1,32 @@
-namespace MsieJavaScriptEngine
+using System;
+
+using MsieJavaScriptEngine.Resources;
+using MsieJavaScriptEngine.Utilities;
+
+namespace MsieJavaScriptEngine
 {
 	/// <summary>
 	/// JS engine settings
 	/// </summary>
 	public sealed class JsEngineSettings
 	{
+#if !NETSTANDARD1_3
+		/// <summary>
+		/// The stack size is sufficient to run the code of modern JavaScript libraries in 32-bit process
+		/// </summary>
+		const int STACK_SIZE_32 = 492 * 1024; // like 32-bit Node.js
+
+		/// <summary>
+		/// The stack size is sufficient to run the code of modern JavaScript libraries in 64-bit process
+		/// </summary>
+		const int STACK_SIZE_64 = 984 * 1024; // like 64-bit Node.js
+
+		/// <summary>
+		/// The maximum stack size in bytes
+		/// </summary>
+		private int _maxStackSize;
+
+#endif
 		/// <summary>
 		/// Gets or sets a flag for whether to enable script debugging features
 		/// </summary>
@@ -22,6 +44,33 @@ public JsEngineMode EngineMode
 			get;
 			set;
 		}
+#if !NETSTANDARD1_3
+
+		/// <summary>
+		/// Gets or sets a maximum stack size in bytes
+		/// </summary>
+		/// <remarks>
+		/// <para>Set a <code>0</code> to use the default maximum stack size specified in the header
+		/// for the executable.
+		/// </para>
+		/// </remarks>
+		public int MaxStackSize
+		{
+			get { return _maxStackSize; }
+			set
+			{
+				if (value < 0)
+				{
+					throw new ArgumentOutOfRangeException(
+						nameof(value),
+						CommonStrings.Engine_MaxStackSizeMustBeNonNegative
+					);
+				}
+
+				_maxStackSize = value;
+			}
+		}
+#endif
 
 		/// <summary>
 		/// Gets or sets a flag for whether to use the ECMAScript 5 Polyfill
@@ -49,6 +98,9 @@ public JsEngineSettings()
 		{
 			EnableDebugging = false;
 			EngineMode = JsEngineMode.Auto;
+#if !NETSTANDARD1_3
+			MaxStackSize = Utils.Is64BitProcess() ? STACK_SIZE_64 : STACK_SIZE_32;
+#endif
 			UseEcmaScript5Polyfill = false;
 			UseJson2Library = false;
 		}

src/MsieJavaScriptEngine/JsRt/ChakraJsRtJsEngineBase.cs

@@ -48,7 +48,11 @@ internal abstract class ChakraJsRtJsEngineBase : InnerJsEngineBase
 		protected ChakraJsRtJsEngineBase(JsEngineSettings settings)
 			: base(settings)
 		{
+#if NETSTANDARD1_3
 			_dispatcher = new ScriptDispatcher();
+#else
+			_dispatcher = new ScriptDispatcher(settings.MaxStackSize);
+#endif
 #if NETSTANDARD
 			_externalObjectFinalizeCallback = ExternalObjectFinalizeCallback;
 #endif

src/MsieJavaScriptEngine/MsieJavaScriptEngine.csproj

@@ -24,7 +24,7 @@
 		<RepositoryUrl>https://github.com/Taritsyn/MsieJavaScriptEngine</RepositoryUrl>
 		<RepositoryType>git</RepositoryType>
 		<PackageTags>JavaScript;ECMAScript;MSIE;IE;Edge;Chakra</PackageTags>
-		<PackageReleaseNotes>Fixed a error, that occurred during the generation of error message.</PackageReleaseNotes>
+		<PackageReleaseNotes>In JavaScript engine settings was added one new property - `MaxStackSize` (default `492` or `984` KB).</PackageReleaseNotes>
 		<NeutralLanguage>en-US</NeutralLanguage>
 		<PackageOutputPath>../../nuget</PackageOutputPath>
 		<GeneratePackageOnBuild>true</GeneratePackageOnBuild>

src/MsieJavaScriptEngine/Resources/CommonStrings.Designer.cs

@@ -150,6 +150,9 @@
   <data name="Engine_JsEngineNotLoaded" xml:space="preserve">
     <value>Failed to create instance of the MsieJsEngine in {0} mode.</value>
   </data>
+  <data name="Engine_MaxStackSizeMustBeNonNegative" xml:space="preserve">
+    <value>Maximum stack size must be non-negative.</value>
+  </data>
   <data name="ErrorDetails_CallStack" xml:space="preserve">
     <value>Call stack</value>
   </data>

src/MsieJavaScriptEngine/Resources/CommonStrings.resx

@@ -150,6 +150,9 @@
   <data name="Engine_JsEngineNotLoaded" xml:space="preserve">
     <value>Не удалось создать экземпляр MsieJsEngine в режиме {0}.</value>
   </data>
+  <data name="Engine_MaxStackSizeMustBeNonNegative" xml:space="preserve">
+    <value>Максимальный размер стека должен быть неотрицательным!</value>
+  </data>
   <data name="ErrorDetails_CallStack" xml:space="preserve">
     <value>Стек вызовов</value>
   </data>

src/MsieJavaScriptEngine/Resources/CommonStrings.ru-ru.resx

@@ -1,35 +1,25 @@
 using System;
 using System.Collections.Generic;
+using System.Runtime.CompilerServices;
 #if NET45 || NETSTANDARD
 using System.Runtime.ExceptionServices;
 #endif
-using System.Runtime.CompilerServices;
 using System.Threading;
 
+#if NET40
 using MsieJavaScriptEngine.Extensions;
+#endif
 using MsieJavaScriptEngine.Utilities;
 
 namespace MsieJavaScriptEngine
 {
 	/// <summary>
-	/// Provides services for managing the queue of script tasks on the thread with increased stack size
+	/// Provides services for managing the queue of script tasks on the thread with modified stack size
 	/// </summary>
 	internal sealed class ScriptDispatcher : IDisposable
 	{
-#if !NETSTANDARD1_3
 		/// <summary>
-		/// The stack size is sufficient to run the code of modern JS libraries in 32-bit process
-		/// </summary>
-		const int STACK_SIZE_32 = 492 * 1024; // like 32-bit Node.js
-
-		/// <summary>
-		/// The stack size is sufficient to run the code of modern JS libraries in 64-bit process
-		/// </summary>
-		const int STACK_SIZE_64 = 984 * 1024; // like 64-bit Node.js
-
-#endif
-		/// <summary>
-		/// The thread with increased stack size
+		/// The thread with modified stack size
 		/// </summary>
 		private Thread _thread;
 
@@ -54,17 +44,22 @@ internal sealed class ScriptDispatcher : IDisposable
 		private InterlockedStatedFlag _disposedFlag = new InterlockedStatedFlag();
 
 
+#if NETSTANDARD1_3
 		/// <summary>
 		/// Constructs an instance of script dispatcher
 		/// </summary>
 		public ScriptDispatcher()
 		{
-#if NETSTANDARD1_3
 			_thread = new Thread(StartThread)
 #else
-			int sufficientStackSize = Utils.Is64BitProcess() ? STACK_SIZE_64 : STACK_SIZE_32;
-
-			_thread = new Thread(StartThread, sufficientStackSize)
+		/// <summary>
+		/// Constructs an instance of script dispatcher
+		/// </summary>
+		/// <param name="maxStackSize">The maximum stack size, in bytes, to be used by the thread,
+		/// or 0 to use the default maximum stack size specified in the header for the executable.</param>
+		public ScriptDispatcher(int maxStackSize)
+		{
+			_thread = new Thread(StartThread, maxStackSize)
 #endif
 			{
 				IsBackground = true
@@ -83,7 +78,7 @@ private void VerifyNotDisposed()
 		}
 
 		/// <summary>
-		/// Starts a thread with increased stack size.
+		/// Starts a thread with modified stack size.
 		/// Loops forever, processing script tasks from the queue.
 		/// </summary>
 		private void StartThread()
@@ -139,7 +134,7 @@ private void EnqueueTask(ScriptTask task)
 		}
 
 		/// <summary>
-		/// Runs a specified delegate on the thread with increased stack size,
+		/// Runs a specified delegate on the thread with modified stack size,
 		/// and returns its result as an <see cref="System.Object"/>.
 		/// Blocks until the invocation of delegate is completed.
 		/// </summary>
@@ -174,7 +169,7 @@ private object InnnerInvoke(Func<object> del)
 		}
 
 		/// <summary>
-		/// Runs a specified delegate on the thread with increased stack size,
+		/// Runs a specified delegate on the thread with modified stack size,
 		/// and returns its result as an <typeparamref name="T" />.
 		/// Blocks until the invocation of delegate is completed.
 		/// </summary>
@@ -195,7 +190,7 @@ public T Invoke<T>(Func<T> func)
 		}
 
 		/// <summary>
-		/// Runs a specified delegate on the thread with increased stack size.
+		/// Runs a specified delegate on the thread with modified stack size.
 		/// Blocks until the invocation of delegate is completed.
 		/// </summary>
 		/// <param name="action">Delegate to invocation</param>

src/MsieJavaScriptEngine/ScriptDispatcher.cs

@@ -21,7 +21,8 @@
    =============
    RELEASE NOTES
    =============
-   Fixed a error, that occurred during the generation of error message.
+   In JavaScript engine settings was added one new property - `MaxStackSize`
+   (default `492` or `984` KB).
 
    ============
    PROJECT SITE